Bug 340233 - View URL is changed to "Home" when opening the Terminal Panel while browsing a remote URL
Summary: View URL is changed to "Home" when opening the Terminal Panel while browsing ...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: terminal (show other bugs)
Version: 4.14.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-22 16:56 UTC by Frank Reininghaus
Modified: 2014-10-23 21:22 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.14.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Reininghaus 2014-10-22 16:56:18 UTC
This issue was first reported in https://bugs.kde.org/show_bug.cgi?id=339009#c6

Reproducible: Always

Steps to Reproduce:
1. Open Dolphin (with hidden Terminal Panel)
2. Go to fish://localhost
3. Click any subfolder of the home folder (which is shown via fish:)
4. Press F4 to open the Terminal Panel.

Actual Results:  
The view URL is changed, and the view shows the home directory.

Expected Results:  
The view URL should not be changed.
Comment 1 Frank Reininghaus 2014-10-22 17:05:32 UTC
https://git.reviewboard.kde.org/r/120726/
Comment 2 Frank Reininghaus 2014-10-23 21:22:06 UTC
Git commit 62c7120acd96f44d5290fa0e16ae071584e8ee68 by Frank Reininghaus.
Committed on 23/10/2014 at 21:17.
Pushed by freininghaus into branch 'KDE/4.14'.

Connect to the currentDirectoryChanged signal after the shell setup

This fixes the problem that the view URL may be reset to the Home URL
when opening the Terminal Panel while browsing a remote URL. Moreover,
it fixes crashes that can occur when the signal is received during the
shell setup if the DolphinMainWindow does not have a valid
m_activeViewContainer yet.
Related: bug 339502
REVIEW: 120726
FIXED-IN: 4.14.3

M  +2    -2    dolphin/src/panels/terminal/terminalpanel.cpp

http://commits.kde.org/kde-baseapps/62c7120acd96f44d5290fa0e16ae071584e8ee68