String: Transport Type: See screenshot. Please, consider that translations can have a larger string. Reproducible: Always
Created attachment 89097 [details] Screenshot
Created attachment 89277 [details] Screenshot I would like to work on this bug, but it seems to be fixed.
(In reply to Mihir Thakkar from comment #2) > Created attachment 89277 [details] > Screenshot > > I would like to work on this bug, but it seems to be fixed. If you zoom in your screenshot, you can see the difference between the "e" characters. (problably you can see better if you change your font size or use a translation with larger string). In addition, the correct string is "Transport Type:" (missing colon in your screenshot) file in master: src/plugins/runner/monav/MonavConfigWidget.ui:55 I'm using Marble 1.9 (KDE 4.14.1)
Hi Mihir, a patch is much welcome. Ideally posted to http://git.reviewboard.kde.org with the marble group as reviewers. Thanks.
We can just shift the widget positions to ensure proper visibility of the strings. But I am not sure whether it is the best solution or not.
Created attachment 89340 [details] modification in the Configure Routing Service UI
Comment on attachment 89340 [details] modification in the Configure Routing Service UI --- src/plugins/runner/monav/MonavConfigWidget.ui | 143 +++++++++++--------------- 1 file changed, 62 insertions(+), 81 deletions(-) diff --git a/src/plugins/runner/monav/MonavConfigWidget.ui b/src/plugins/runner/monav/MonavConfigWidget.ui index 4d7910c..881b9ed 100644 --- a/src/plugins/runner/monav/MonavConfigWidget.ui +++ b/src/plugins/runner/monav/MonavConfigWidget.ui @@ -6,8 +6,8 @@ <rect> <x>0</x> <y>0</y> - <width>286</width> - <height>277</height> + <width>314</width> + <height>303</height> </rect> </property> <property name="sizePolicy"> @@ -19,15 +19,22 @@ <property name="windowTitle"> <string>Monav Configuration</string> </property> - <layout class="QVBoxLayout" name="verticalLayout"> - <item> + <layout class="QFormLayout" name="formLayout_2"> + <item row="0" column="0"> <widget class="QStackedWidget" name="m_stackedWidget"> <property name="currentIndex"> <number>0</number> </property> <widget class="QWidget" name="m_settingsPage"> - <layout class="QVBoxLayout" name="verticalLayout_2"> - <item> + <layout class="QGridLayout" name="gridLayout"> + <item row="1" column="0"> + <widget class="QLabel" name="m_statusLabel"> + <property name="text"> + <string/> + </property> + </widget> + </item> + <item row="0" column="0"> <widget class="QTabWidget" name="monavTabWidget"> <property name="currentIndex"> <number>0</number> @@ -42,71 +49,55 @@ <attribute name="title"> <string>Configure</string> </attribute> - <widget class="QLabel" name="label_2"> - <property name="geometry"> - <rect> - <x>4</x> - <y>4</y> - <width>86</width> - <height>24</height> - </rect> - </property> - <property name="text"> - <string>Transport Type:</string> - </property> - </widget> - <widget class="QComboBox" name="m_transportTypeComboBox"> - <property name="geometry"> - <rect> - <x>94</x> - <y>4</y> - <width>57</width> - <height>24</height> - </rect> - </property> - <property name="sizeAdjustPolicy"> - <enum>QComboBox::AdjustToContents</enum> - </property> - <item> - <property name="text"> - <string>Any</string> - </property> + <layout class="QGridLayout" name="gridLayout_4"> + <item row="0" column="0"> + <widget class="QLabel" name="label_2"> + <property name="text"> + <string>Transport Type:</string> + </property> + </widget> + </item> + <item row="0" column="1"> + <widget class="QComboBox" name="m_transportTypeComboBox"> + <property name="sizeAdjustPolicy"> + <enum>QComboBox::AdjustToContents</enum> + </property> + <item> + <property name="text"> + <string>Any</string> + </property> + </item> + </widget> </item> - </widget> - <widget class="QTableView" name="m_configureMapsListView"> - <property name="geometry"> - <rect> - <x>4</x> - <y>32</y> - <width>254</width> - <height>195</height> - </rect> - </property> - <property name="sizePolicy"> - <sizepolicy hsizetype="MinimumExpanding" vsizetype="MinimumExpanding"> - <horstretch>0</horstretch> - <verstretch>0</verstretch> - </sizepolicy> - </property> - <property name="horizontalScrollBarPolicy"> - <enum>Qt::ScrollBarAlwaysOff</enum> - </property> - <property name="alternatingRowColors"> - <bool>true</bool> - </property> - <attribute name="horizontalHeaderVisible"> - <bool>true</bool> - </attribute> - <attribute name="horizontalHeaderStretchLastSection"> - <bool>false</bool> - </attribute> - <attribute name="verticalHeaderVisible"> - <bool>false</bool> - </attribute> - <attribute name="verticalHeaderStretchLastSection"> - <bool>false</bool> - </attribute> - </widget> + <item row="1" column="0" colspan="2"> + <widget class="QTableView" name="m_configureMapsListView"> + <property name="sizePolicy"> + <sizepolicy hsizetype="MinimumExpanding" vsizetype="MinimumExpanding"> + <horstretch>0</horstretch> + <verstretch>0</verstretch> + </sizepolicy> + </property> + <property name="horizontalScrollBarPolicy"> + <enum>Qt::ScrollBarAlwaysOff</enum> + </property> + <property name="alternatingRowColors"> + <bool>true</bool> + </property> + <attribute name="horizontalHeaderVisible"> + <bool>true</bool> + </attribute> + <attribute name="horizontalHeaderStretchLastSection"> + <bool>false</bool> + </attribute> + <attribute name="verticalHeaderVisible"> + <bool>false</bool> + </attribute> + <attribute name="verticalHeaderStretchLastSection"> + <bool>false</bool> + </attribute> + </widget> + </item> + </layout> </widget> <widget class="QWidget" name="tab_3"> <property name="sizePolicy"> @@ -153,10 +144,7 @@ <attribute name="title"> <string>Install New</string> </attribute> - <layout class="QFormLayout" name="formLayout"> - <property name="fieldGrowthPolicy"> - <enum>QFormLayout::ExpandingFieldsGrow</enum> - </property> + <layout class="QGridLayout" name="gridLayout_2"> <item row="0" column="0"> <widget class="QLabel" name="label"> <property name="text"> @@ -210,13 +198,6 @@ </widget> </widget> </item> - <item> - <widget class="QLabel" name="m_statusLabel"> - <property name="text"> - <string/> - </property> - </widget> - </item> </layout> </widget> <widget class="QWidget" name="m_progressPage"> -- 1.9.1
Git commit 4a3206427113025c036eaefefeab657b5065d763 by Bernhard Beschow, on behalf of Mihir Thakkar. Committed on 28/12/2014 at 13:38. Pushed by beschow into branch 'master'. Ensure whole text is visible in MonavConfigWidget. REVIEW: 120797 M +53 -65 src/plugins/runner/monav/MonavConfigWidget.ui http://commits.kde.org/marble/4a3206427113025c036eaefefeab657b5065d763
Git commit 1f9f7c93c5699522fdc6ec0ed2ba03582108a50f by Bernhard Beschow, on behalf of Mihir Thakkar. Committed on 28/12/2014 at 13:38. Pushed by beschow into branch 'KDE/4.14'. Ensure whole text is visible in MonavConfigWidget. REVIEW: 120797 (cherry picked from commit 4a3206427113025c036eaefefeab657b5065d763) M +53 -65 src/plugins/runner/monav/MonavConfigWidget.ui http://commits.kde.org/marble/1f9f7c93c5699522fdc6ec0ed2ba03582108a50f