Bug 339852 - [Tool docker] can't be reduced to make single column tool layout look nice
Summary: [Tool docker] can't be reduced to make single column tool layout look nice
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: git master (please specify the git hash!)
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-10 19:58 UTC by David REVOY
Modified: 2014-12-15 04:12 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
[^ screenshot of the tool docker with annotations ] (50.73 KB, image/png)
2014-10-10 19:58 UTC, David REVOY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2014-10-10 19:58:47 UTC
Created attachment 89083 [details]
[^ screenshot of the tool docker with annotations ]

Hi,
I just installed krita-testing lime ppa from ppa:dimula73/krita, and the tool docker can't be reduced to make single column layout look nice as it was possible on 2.8.  I join a screenshot to show the issue ( a big padding on the right ). 
I also spotted the issue on this screen record of 2.9git master :
https://www.youtube.com/watch?v=esSzKzXVWQE
Comment 1 Sven Langkamp 2014-10-10 20:55:45 UTC
The problem is that with the lock icon and the float icon the docker is too wide to make it smaller. Currently the only way around that is to look the docker and then resize it.
Comment 2 Halla Rempt 2014-10-15 21:08:10 UTC
The only solution I see is to make the toolbox either a minimum of two columns, or to remove the float button.
Comment 3 vanyossi 2014-10-18 00:42:42 UTC
My vote is to remove the lock button (is this the float button?)
Making the toolbox limit to two columns generates a big wasted space area below the buttons.

what I end up doing is locking the toolbox docker and resizing every session (why the toolbox can't remember to stay locked?)
Comment 4 Scott Petrovic 2014-10-18 13:58:15 UTC
I think this brings up a larger issue of showing too many tools on the toolbar by default. We need some way to display them so they don't take up so much space. Is doing something like a "combo box of buttons" like other applications have (Photoshop, Painter). It would be a nice way to organize the tools by type.  It would clear up *a lot* of space as well. I like a one column tool docker, but it does get rather long and not work with most monitor sizes.
Comment 5 Scott Petrovic 2014-10-19 15:59:19 UTC
doh, I actually understand what the issue is now after looking at it today. 

If you have the toolbar unlocked, it removes the "float docker" icon.  That allows you to shrink the toolbar down so the single column looks better. That seems to work for me in Ubuntu
Comment 6 David REVOY 2014-10-22 12:50:46 UTC
@vanyossi 
>> [...] and resizing every session (why the toolbox can't remember to stay locked?)
Similar issue here, I'm locking and resizing before each session the toolbox...
It might appear a minor bug, but this one is for the moment my top annoying bug with 2.9alpha.  xD  This and the lock icon itself everywhere.
Comment 7 Scott Petrovic 2014-10-22 13:36:31 UTC
hmmm. Is the lock icon important enough to always be visible on the UI? I haven't really used the lock toggle very much. It doesn't seem to add much value (maybe I am not understanding why I would need it). How does this help the drawing or painting process.

What situations come up where where this option is useful? If it is not important enough to be visible at all times, maybe it would be better to hide that option behind a right/context click so if someone wants it, they can turn it on. You can turn off toolbar options and dockers already with this.
Comment 8 Sven Langkamp 2014-10-22 20:08:14 UTC
Git commit 9be98e5cf293b55d247a3e0a911bad1c0021c946 by Sven Langkamp.
Committed on 22/10/2014 at 20:07.
Pushed by langkamp into branch 'master'.

hide lock button if docker gets to small
REVIEW:120730

M  +5    -1    libs/widgets/KoDockWidgetTitleBar.cpp

http://commits.kde.org/calligra/9be98e5cf293b55d247a3e0a911bad1c0021c946
Comment 9 Chris Jones 2014-12-14 23:36:20 UTC
This issue has resurfaced, except that now there are two full columns of tools, and it can't be reduced to one, no matter what (even though there is ample room for a single column on a 2560 x 1440 monitor).

Krita 2.8.90.1, Windows 8.1 64 bit
Comment 10 vanyossi 2014-12-15 04:12:32 UTC
I'm getting the same problem. This makes some space inevitable lost in big screen resolutions.

2.9 Beta 1