Bug 339303 - ToolButton: Binding loop when no text is set
Summary: ToolButton: Binding loop when no text is set
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
: 343055 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-09-22 14:57 UTC by David Edmundson
Modified: 2015-02-17 22:22 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Edmundson 2014-09-22 14:57:18 UTC
background changes depend  goes round if width == height
ToolButtonStyle:109

button size is dependent on the background implicit sizes
(QQC ButtonStyle.qml: 155)

as far as QML is concerned: background implicit size depends on which background is chosen.
hence loop. 

Not sure on what a good fix is. Options are:
1) put the circle/square stuff in a loader put the implicit size stuff on the loader rather than the component
2) drop the if width == height check (one shouldn't meddle with sizes of buttons anyway)
3) something horrible with timers.
Comment 1 Kai Uwe Broulik 2015-02-17 22:21:26 UTC
*** Bug 343055 has been marked as a duplicate of this bug. ***
Comment 2 Kai Uwe Broulik 2015-02-17 22:22:03 UTC
Git commit 2a4812c9ba9d54ba759273efe84353ffd6e8d22c by Kai Uwe Broulik.
Committed on 17/02/2015 at 22:15.
Pushed by broulik into branch 'master'.

Drop size check for round ToolButton

It causes binding loops causing all sorts of weird behavior, like the buttons
in Klipper not always having a background.

Changelog: Fix rendering glitches with ToolButtons that don't have a label

REVIEW: 122609
Related: bug 340588

M  +1    -1    src/declarativeimports/plasmastyle/ToolButtonStyle.qml

http://commits.kde.org/plasma-framework/2a4812c9ba9d54ba759273efe84353ffd6e8d22c