After opening new tab in dolphin, tabs strip steals focus from files area Reproducible: Always Steps to Reproduce: 1. open dolphin 2. open new tab 3. try to navigate through files with keyboard Actual Results: focus is tab strip Expected Results: focus should be on files area
* Actual Results: focus is on tab strip fixed also, previous versions work as expected
Review-Request: https://git.reviewboard.kde.org/r/120125/ Feel free to give some feedback if you can test it ;)
And I can reproduce this problem. (-> confirmed)
Git commit ce25c19a837655214961ee7753079ca00d7868ed by Emmanuel Pescosta. Committed on 09/09/2014 at 22:23. Pushed by emmanuelp into branch 'master'. Set the focus to the active view if the current tab has been changed. FIXED-IN: 4.15.0 REVIEW: 120125 M +1 -0 dolphin/src/dolphintabwidget.cpp http://commits.kde.org/kde-baseapps/ce25c19a837655214961ee7753079ca00d7868ed
Hi, Emmanuel. I encountered this bug after upgrading to 4.14.2 a few days ago, and it's been driving me crazy. Didn't realize just what was happening until earlier tonight, and it's awesome that you've already fixed this. Thanks. One question, though - I tried applying your patch (which appears to target 4.15) to the 4.14.2 source, but it doesn't apply. The section of code you're modifying doesn't even appear to be in the 14.2 source, so I'm having trouble figuring out how to backport it myself. I know this should be fixed in 4.15, but man, I'm such a heavy tab user in my file manager that I don't think I can wait that long. Is there any chance you could provide either some pointers or perhaps an unofficial patch to address this in 4.14? Otherwise, I may have to downgrade to 4.13, but I'd really hate to go that route. Thanks for your consideration.
Created attachment 89634 [details] Unofficial patch for Dolphin 4.14 This patch isn't officially supported by the Dolphin developers, it's just a small patch to fix the problem for the 4.14 release, because backporting the patch from 14.12 isn't possible.
(In reply to Jared B. from comment #5) > One question, though - I tried applying your patch (which appears to target > 4.15) to the 4.14.2 source, but it doesn't apply. The section of code > you're modifying doesn't even appear to be in the 14.2 source, so I'm having > trouble figuring out how to backport it myself. We did a huge refactoring of all the tabbing related code and unfortunately the freeze of 4.14 happened in the middle of the ongoing refactoring. So a simple backport isn't possible. > Is there any chance you could provide either > some pointers or perhaps an unofficial patch to address this in 4.14? > Otherwise, I may have to downgrade to 4.13, but I'd really hate to go that > route. For Dolphin 4.14 you can apply the attached patch. I hope it helps! ;)
Thank you! Installing this now. And yeah, the unsupported thing is understoond.
*** Bug 339035 has been marked as a duplicate of this bug. ***
*** Bug 381269 has been marked as a duplicate of this bug. ***