Bug 337712 - Breeze theme screen edge glow is too large
Summary: Breeze theme screen edge glow is too large
Status: RESOLVED INTENTIONAL
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-22 22:15 UTC by enoopt.adams
Modified: 2019-02-08 10:52 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Picture of the problem, the glow is about twice as large as it needs to be (35.80 KB, image/png)
2014-07-22 22:15 UTC, enoopt.adams
Details
Glow in virtual box (8.36 KB, image/png)
2014-08-03 06:10 UTC, enoopt.adams
Details
XRender screenshot (2.77 KB, image/png)
2014-08-09 19:16 UTC, enoopt.adams
Details
Support info (4.72 KB, text/plain)
2014-08-09 19:32 UTC, Thomas Lübking
Details
Output of command (4.72 KB, text/plain)
2014-08-09 19:47 UTC, enoopt.adams
Details

Note You need to log in before you can comment on or make changes to this bug.
Description enoopt.adams 2014-07-22 22:15:55 UTC
Created attachment 87887 [details]
Picture of the problem, the glow is about twice as large as it needs to be

The light blue glow that appears on screen edges that have something bound to them is huge. It's very distracting if I need to click on something in the corner of the screen, the glow covers everything underneath it.
Comment 1 Andrew Lake 2014-07-24 16:09:06 UTC
Agreed. Is this still implemented in the plasma theme? If so I can take the assignment to update the Breeze plasma theme.
Comment 2 Thomas Lübking 2014-07-31 16:17:30 UTC
widgets/glowbar/bottomright
widgets/glowbar/bottomleft
widgets/glowbar/topleft
widgets/glowbar/topright
widgets/glowbar/top
widgets/glowbar/bottom
widgets/glowbar/left
widgets/glowbar/right

The requested size is calculated as
    (physicalDpiX + physicalDpiY + 5) / 6

ie. if you're running 120dpi it's 40px and on 72dpi it's 25px
This matches the area where the thing starts to fade in.

You can btw. disable the effect (kcmshell4 kwincompositing, 2nd tab) what is one of the first things I do on new setups ;-P
Comment 3 enoopt.adams 2014-08-03 06:09:46 UTC
I like the effect, it's just so huge. It's almost 300 percent larger than it was in kde4.Compare the size between the glow in a virtual box and my laptop. The glow is covering the window buttons.
Comment 4 enoopt.adams 2014-08-03 06:10:07 UTC
Created attachment 88090 [details]
Glow in virtual box
Comment 5 Thomas Lübking 2014-08-03 07:28:18 UTC
what's the output of
   xdpyinfo | grep resolution
in either context?
Comment 6 enoopt.adams 2014-08-03 08:32:30 UTC
Both show 96 dpi
Comment 7 Thomas Lübking 2014-08-03 09:24:28 UTC
same with xrender? (on KF5/PN)

There's certainly a bug here (the glow image is also visibly clamped), but we need to figure where.
The way the size is calculated didn't change, so either there's a bug in KWin's rendering or plasma's image generation.
Comment 8 enoopt.adams 2014-08-08 07:40:33 UTC
How can I figure out where the problem lies?
Comment 9 Thomas Lübking 2014-08-08 10:54:59 UTC
Check the xrender backend (3rd tab in the compositing kcm)
If it's too big with that as well, there's a good chance that plasma returns an oversized image (more likely that both renderes are broken in the same way)

Other than that you'd have to compile a patch to debug out the generated image.
Comment 10 enoopt.adams 2014-08-09 19:16:27 UTC
Created attachment 88188 [details]
XRender screenshot
Comment 11 Thomas Lübking 2014-08-09 19:17:54 UTC
Aha ;-)

Get back to opengl and post the output of

   qdbus org.kde.KWin /KWin supportInformation
Comment 12 enoopt.adams 2014-08-09 19:18:53 UTC
It does seem that the Xrender backend "fixes" the problem. I would say that the screen glow is too small in that backend. It's very difficult to see.
Comment 13 enoopt.adams 2014-08-09 19:21:43 UTC
http://pastebin.com/TC2Nye4L
Output of command.
Comment 14 Thomas Lübking 2014-08-09 19:32:02 UTC
Created attachment 88189 [details]
Support info

Please always attach to the bug, pastebin has a limited lifetime.
Comment 15 Thomas Lübking 2014-08-09 19:33:57 UTC
Can you check the behavior with
a) OpenGL 2.0
b) w/o the zoom effect enabled?
Comment 16 enoopt.adams 2014-08-09 19:47:03 UTC
Created attachment 88190 [details]
Output of command
Comment 17 enoopt.adams 2014-08-09 19:50:41 UTC
Neither opengl 2.0 nor disabling zoom changes anything.
Comment 18 Vlad Zahorodnii 2019-02-07 22:36:13 UTC
@Martin It looks like the corner glows are scaled with OpenGL compositing. Is it intentional?
Comment 19 Martin Flöser 2019-02-08 04:59:17 UTC
Iirc it is intended
Comment 20 Vlad Zahorodnii 2019-02-08 10:52:33 UTC
Marking as RESOLVED INTENTIONAL per Martin's comment.