Bug 335519 - Build fails with giflib 5.1.0
Summary: Build fails with giflib 5.1.0
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Unmaintained
Component: WLM Plugin (other bugs)
Version First Reported In: 1.7.1
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-29 12:20 UTC by Andrea Scarpino
Modified: 2014-10-20 09:01 UTC (History)
2 users (show)

See Also:
Latest Commit: 0d4f91d8b957a749ee375be5294e330182c61f4c
Version Fixed In: 4.14.1
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Andrea Scarpino 2014-05-29 12:20:34 UTC 
/build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp: In member function 'void WlmChatSession::convertToGif(const QPixmap&, QString)':
/build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:560:30: error: too few arguments to function 'int EGifCloseFile(GifFileType*, int*)'
         EGifCloseFile(GifFile);
                              ^
In file included from /build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:67:0:
/usr/include/gif_lib.h:132:5: note: declared here
 int EGifCloseFile(GifFileType *GifFile, int *ErrorCode);
     ^
/build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:583:30: error: too few arguments to function 'int EGifCloseFile(GifFileType*, int*)'
         EGifCloseFile(GifFile);
                              ^
In file included from /build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:67:0:
/usr/include/gif_lib.h:132:5: note: declared here
 int EGifCloseFile(GifFileType *GifFile, int *ErrorCode);
     ^
/build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:587:30: error: too few arguments to function 'int EGifCloseFile(GifFileType*, int*)'
     if (EGifCloseFile(GifFile) != GIF_OK) {
                              ^
In file included from /build/kdenetwork-kopete/src/kopete-4.13.1/protocols/wlm/wlmchatsession.cpp:67:0:
/usr/include/gif_lib.h:132:5: note: declared here
 int EGifCloseFile(GifFileType *GifFile, int *ErrorCode);
     ^
protocols/wlm/CMakeFiles/kopete_wlm.dir/build.make:307: recipe for target 'protocols/wlm/CMakeFiles/kopete_wlm.dir/wlmchatsession.o' failed
make[2]: *** [protocols/wlm/CMakeFiles/kopete_wlm.dir/wlmchatsession.o] Error 1

Reproducible: Always

Steps to Reproduce:
1. Update giflib to 5.1.0
2. Try to build kopete
Actual Results:  
Build fails

Expected Results:  
It builds.

giflib 5.1.0
Comment 1 Raymond Wooninck 2014-09-03 11:15:56 UTC 
Created a review request for a possible solution.  

https://git.reviewboard.kde.org/r/120047/
Comment 2 Raymond Wooninck 2014-09-05 21:41:49 UTC 
Git commit 0d4f91d8b957a749ee375be5294e330182c61f4c by Raymond Wooninck.
Committed on 05/09/2014 at 21:40.
Pushed by rwooninck into branch 'KDE/4.14'.

Make Kopete build with giflib 5.1.0 and up.

REVIEW: 120047

M  +13   -3    protocols/wlm/wlmchatsession.cpp

http://commits.kde.org/kopete/0d4f91d8b957a749ee375be5294e330182c61f4c
Comment 3 Christoph Feck 2014-09-14 12:04:41 UTC 
Andrea, does 4.14.1 build correctly now?