Inserting report elements could be improved. Wish 1. After inserting item it should be selected. Bug 2. After inserting item by drawing rectangle, the item's geometry should match the rectangle's geometry. Wish 3. Moving items using mouse drag between report's sections should be possible. Wish 4. Resizing report section may hide elements. This can cause a situation when user has items that are hard to locate. To fix that, resize sections only when a new size does not cover any items in this section. This is how Form Designer behaves regarding resizing of its geometry. Bug 5. Resizing report item should stop when user approaches boundary of the report section. Currently resized item unexpectedly grows. Reproducible: Always
Git commit 0df735b52b3ca42aa28269894aeb40f191b0a7d0 by Wojciech Kosowicz. Committed on 29/06/2014 at 21:57. Pushed by wkosowicz into branch 'calligra/2.8'. Added selecting item after it is added in Kexi's report REVIEW: 119002 M +3 -0 libs/koreport/wrtembed/KoReportDesigner.cpp http://commits.kde.org/calligra/0df735b52b3ca42aa28269894aeb40f191b0a7d0
Git commit 267d9da323dd366c3ea596db9fca2bb97972e630 by Wojciech Kosowicz. Committed on 29/06/2014 at 21:57. Pushed by wkosowicz into branch 'master'. Added selecting item after it is added in Kexi's report REVIEW: 119002 M +3 -0 libs/koreport/wrtembed/KoReportDesigner.cpp http://commits.kde.org/calligra/267d9da323dd366c3ea596db9fca2bb97972e630
Just noticed, https://bugs.kde.org/show_bug.cgi?id=334967 has more sub-issues, so I think we'll reopen it? On 30 June 2014 00:06, Wojciech Kosowicz <pcellix@gmail.com> wrote: > Wojciech Kosowicz <pcellix@gmail.com> changed bug 334967 > <https://bugs.kde.org/show_bug.cgi?id=334967> > What Removed Added Latest Commit > http://commits.kde.org/calligra/0df735b52b3ca42aa28269894aeb40f191b0a7d0 > http://commits.kde.org/calligra/267d9da323dd366c3ea596db9fca2bb97972e630 > > *Comment # 2 <https://bugs.kde.org/show_bug.cgi?id=334967#c2> on bug > 334967 <https://bugs.kde.org/show_bug.cgi?id=334967> from Wojciech Kosowicz > <pcellix@gmail.com> * > > Git commit 267d9da323dd366c3ea596db9fca2bb97972e630 by Wojciech Kosowicz. > Committed on 29/06/2014 at 21:57. > Pushed by wkosowicz into branch 'master'. > > Added selecting item after it is added in Kexi's report > REVIEW: 119002 > > M +3 -0 libs/koreport/wrtembed/KoReportDesigner.cpp > http://commits.kde.org/calligra/267d9da323dd366c3ea596db9fca2bb97972e630 > > ------------------------------ > You are receiving this mail because: > > - You reported the bug. > - You are watching the assignee of the bug. > - You are watching someone on the CC list of the bug. > >
No ja planuje punkt po punkcie to rozwiązać. Tak teraz mam już komputer wyłączony więc jeśli jeszcze jesteś przy komputerze tu otwórz tego bug. Dziękuję Pozdrawiam Wojtek 30 cze 2014 00:10 "Jarosław Staniek" <staniek@kde.org> napisał(a): > https://bugs.kde.org/show_bug.cgi?id=334967 > > Jarosław Staniek <staniek@kde.org> changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Status|RESOLVED |CLOSED > > -- > You are receiving this mail because: > You are on the CC list for the bug. > You are the assignee for the bug.
Reopening so other sub-wishes can be implemented.
While working with reports I have noticed two issues that bothered me: 1. For copying, cutting, deleting, pasting of reports elements typical shortcuts were not active i.e (Ctrl+C for copying etc.) 2. I noticed that after pasting the element is exactly in the same position that the previous element and not active (My patch puts it in the left upper corner) As mentioned I have prepared patches for both of this issues. I will wait with posting for review until staniek comes back. As he knows this programme as nobody else does
Well, i should be able to review it ... i did write the report plugin ;)
Okay, reviews are active
Git commit 6ddfb72e0276fd783d677645b3abd84306b4303b by Wojciech Kosowicz. Committed on 08/09/2014 at 17:18. Pushed by wkosowicz into branch 'calligra/2.8'. Added feature of creating report's items of specific size at adding time When adding any element in kexi report it will the same size as specified by the user at the moment of adding FIXED-IN: 2.8.6 REVIEW: 119527 Conflicts: libs/koreport/items/image/KoReportDesignerItemImage.cpp M +13 -7 libs/koreport/items/check/KoReportDesignerItemCheck.cpp M +5 -1 libs/koreport/items/check/KoReportDesignerItemCheck.h M +15 -9 libs/koreport/items/field/KoReportDesignerItemField.cpp M +3 -3 libs/koreport/items/field/KoReportDesignerItemField.h M +15 -9 libs/koreport/items/image/KoReportDesignerItemImage.cpp M +2 -1 libs/koreport/items/image/KoReportDesignerItemImage.h M +14 -8 libs/koreport/items/label/KoReportDesignerItemLabel.cpp M +5 -2 libs/koreport/items/label/KoReportDesignerItemLabel.h M +14 -8 libs/koreport/items/text/KoReportDesignerItemText.cpp M +3 -2 libs/koreport/items/text/KoReportDesignerItemText.h M +53 -2 libs/koreport/wrtembed/KoReportDesigner.cpp M +26 -1 libs/koreport/wrtembed/KoReportDesigner.h M +1 -1 libs/koreport/wrtembed/KoReportDesignerItemBase.cpp M +1 -1 libs/koreport/wrtembed/KoReportDesignerItemBase.h M +7 -1 libs/koreport/wrtembed/KoReportDesignerItemLine.cpp M +2 -0 libs/koreport/wrtembed/KoReportDesignerItemLine.h M +3 -2 libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp M +8 -1 libs/koreport/wrtembed/KoReportDesignerItemRectBase.h M +6 -0 libs/koreport/wrtembed/reportsceneview.cpp M +1 -0 libs/koreport/wrtembed/reportsceneview.h M +13 -8 plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp M +3 -1 plugins/reporting/barcode/KoReportDesignerItemBarcode.h M +13 -7 plugins/reporting/maps/KoReportDesignerItemMaps.cpp M +2 -1 plugins/reporting/maps/KoReportDesignerItemMaps.h M +13 -12 plugins/reporting/web/KoReportDesignerItemWeb.cpp M +1 -0 plugins/reporting/web/KoReportDesignerItemWeb.h http://commits.kde.org/calligra/6ddfb72e0276fd783d677645b3abd84306b4303b
Git commit 73c9d405ab1e1db8f4b5c58968f950c18113a8ec by Wojciech Kosowicz. Committed on 08/09/2014 at 17:18. Pushed by wkosowicz into branch 'master'. Added feature of creating report's items of specific size at adding time When adding any element in kexi report it will the same size as specified by the user at the moment of adding FIXED-IN: 2.8.6 REVIEW: 119527 M +13 -7 libs/koreport/items/check/KoReportDesignerItemCheck.cpp M +5 -1 libs/koreport/items/check/KoReportDesignerItemCheck.h M +15 -9 libs/koreport/items/field/KoReportDesignerItemField.cpp M +3 -3 libs/koreport/items/field/KoReportDesignerItemField.h M +13 -7 libs/koreport/items/image/KoReportDesignerItemImage.cpp M +2 -1 libs/koreport/items/image/KoReportDesignerItemImage.h M +14 -8 libs/koreport/items/label/KoReportDesignerItemLabel.cpp M +5 -2 libs/koreport/items/label/KoReportDesignerItemLabel.h M +14 -8 libs/koreport/items/text/KoReportDesignerItemText.cpp M +3 -2 libs/koreport/items/text/KoReportDesignerItemText.h M +53 -2 libs/koreport/wrtembed/KoReportDesigner.cpp M +26 -1 libs/koreport/wrtembed/KoReportDesigner.h M +1 -1 libs/koreport/wrtembed/KoReportDesignerItemBase.cpp M +1 -1 libs/koreport/wrtembed/KoReportDesignerItemBase.h M +7 -1 libs/koreport/wrtembed/KoReportDesignerItemLine.cpp M +2 -0 libs/koreport/wrtembed/KoReportDesignerItemLine.h M +3 -2 libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp M +8 -1 libs/koreport/wrtembed/KoReportDesignerItemRectBase.h M +6 -0 libs/koreport/wrtembed/reportsceneview.cpp M +1 -0 libs/koreport/wrtembed/reportsceneview.h M +13 -8 plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp M +3 -1 plugins/reporting/barcode/KoReportDesignerItemBarcode.h M +13 -7 plugins/reporting/maps/KoReportDesignerItemMaps.cpp M +2 -1 plugins/reporting/maps/KoReportDesignerItemMaps.h M +13 -12 plugins/reporting/web/KoReportDesignerItemWeb.cpp M +1 -0 plugins/reporting/web/KoReportDesignerItemWeb.h http://commits.kde.org/calligra/73c9d405ab1e1db8f4b5c58968f950c18113a8ec
Git commit db6739dfc4ec54ace08776d8e03e31737d3a8ae9 by Wojciech Kosowicz. Committed on 19/09/2014 at 12:32. Pushed by wkosowicz into branch 'calligra/2.8'. Pasting kexi report item with offset to active item or right corner When pasting item in kexi report it is either pasted with offset +10, +10 to currently seletected item or it is pasted in the right up corner if currently there is not selected any item FIXED-IN: 2.8.6 REVIEW: 119369 M +12 -0 libs/koreport/wrtembed/KoReportDesigner.cpp http://commits.kde.org/calligra/db6739dfc4ec54ace08776d8e03e31737d3a8ae9
Git commit e15f4cc467e0a6cf9afcc9e6c05f5f5ee05006c5 by Wojciech Kosowicz. Committed on 19/09/2014 at 12:32. Pushed by wkosowicz into branch 'master'. Pasting kexi report item with offset to active item or right corner When pasting item in kexi report it is either pasted with offset +10, +10 to currently seletected item or it is pasted in the right up corner if currently there is not selected any item FIXED-IN: 2.8.6 REVIEW: 119369 M +13 -0 libs/koreport/wrtembed/KoReportDesigner.cpp http://commits.kde.org/calligra/e15f4cc467e0a6cf9afcc9e6c05f5f5ee05006c5
Git commit e27d3c577f5cb2edaeec4133a1c2eae10520b8ad by Jaroslaw Staniek, on behalf of Wojciech Kosowicz. Committed on 19/09/2014 at 12:32. Pushed by staniek into branch 'master'. Pasting kexi report item with offset to active item or right corner When pasting item in kexi report it is either pasted with offset +10, +10 to currently seletected item or it is pasted in the right up corner if currently there is not selected any item FIXED-IN: 2.8.6 REVIEW: 119369 M +3 -1 libs/koreport/wrtembed/KoReportDesigner.cpp http://commits.kde.org/calligra/e27d3c577f5cb2edaeec4133a1c2eae10520b8ad
@Wojciech Can this task be closed? It got only auto-resolved.
*** Bug 339250 has been marked as a duplicate of this bug. ***
keep it open, there's still more work to improve reports user experience. changes 2.8.6 are just the beginning :)
Good idea!
Git commit bcfa4df7087cb47e31bbe07688e3635ebb8a4a05 by Wojciech Kosowicz. Committed on 01/11/2014 at 23:17. Pushed by wkosowicz into branch 'master'. Added possibility of creating kexi reports elements in any direction Added possibility of creating report elements no matter where mouse was pressed and where it was released. Any direction will work. Also minium size elements are moved to fit exactly the scene and do not go out of it in case mouse release took place out of scene FIXED-IN: 2.9 REVIEW: 120634 M +1 -9 libs/koreport/items/check/KoReportDesignerItemCheck.cpp M +3 -3 libs/koreport/items/check/KoReportDesignerItemCheck.h M +1 -9 libs/koreport/items/field/KoReportDesignerItemField.cpp M +0 -1 libs/koreport/items/field/KoReportDesignerItemField.h M +1 -9 libs/koreport/items/image/KoReportDesignerItemImage.cpp M +0 -1 libs/koreport/items/image/KoReportDesignerItemImage.h M +1 -9 libs/koreport/items/label/KoReportDesignerItemLabel.cpp M +0 -3 libs/koreport/items/label/KoReportDesignerItemLabel.h M +1 -9 libs/koreport/items/text/KoReportDesignerItemText.cpp M +0 -1 libs/koreport/items/text/KoReportDesignerItemText.h M +7 -2 libs/koreport/wrtembed/KoReportDesigner.cpp M +5 -0 libs/koreport/wrtembed/KoReportDesigner.h M +37 -1 libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp M +5 -2 libs/koreport/wrtembed/KoReportDesignerItemRectBase.h M +1 -9 plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp M +0 -1 plugins/reporting/barcode/KoReportDesignerItemBarcode.h M +1 -9 plugins/reporting/maps/KoReportDesignerItemMaps.cpp M +0 -1 plugins/reporting/maps/KoReportDesignerItemMaps.h M +1 -9 plugins/reporting/web/KoReportDesignerItemWeb.cpp M +0 -1 plugins/reporting/web/KoReportDesignerItemWeb.h http://commits.kde.org/calligra/bcfa4df7087cb47e31bbe07688e3635ebb8a4a05
Git commit 67ca698da69f86ceac669821ba33a6b18576ef18 by Jaroslaw Staniek, on behalf of Wojciech Kosowicz. Committed on 01/11/2014 at 23:17. Pushed by staniek into branch 'calligra/2.8'. Added possibility of creating kexi reports elements in any direction Added possibility of creating report elements no matter where mouse was pressed and where it was released. Any direction will work. Also minium size elements are moved to fit exactly the scene and do not go out of it in case mouse release took place out of scene REVIEW: 120634 backported from 2.9 M +2 -10 libs/koreport/items/check/KoReportDesignerItemCheck.cpp M +3 -3 libs/koreport/items/check/KoReportDesignerItemCheck.h M +1 -9 libs/koreport/items/field/KoReportDesignerItemField.cpp M +0 -1 libs/koreport/items/field/KoReportDesignerItemField.h M +1 -9 libs/koreport/items/image/KoReportDesignerItemImage.cpp M +0 -1 libs/koreport/items/image/KoReportDesignerItemImage.h M +1 -9 libs/koreport/items/label/KoReportDesignerItemLabel.cpp M +0 -3 libs/koreport/items/label/KoReportDesignerItemLabel.h M +1 -9 libs/koreport/items/text/KoReportDesignerItemText.cpp M +0 -1 libs/koreport/items/text/KoReportDesignerItemText.h M +7 -2 libs/koreport/wrtembed/KoReportDesigner.cpp M +5 -0 libs/koreport/wrtembed/KoReportDesigner.h M +37 -1 libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp M +5 -2 libs/koreport/wrtembed/KoReportDesignerItemRectBase.h M +1 -9 plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp M +0 -1 plugins/reporting/barcode/KoReportDesignerItemBarcode.h M +1 -10 plugins/reporting/maps/KoReportDesignerItemMaps.cpp M +0 -1 plugins/reporting/maps/KoReportDesignerItemMaps.h M +1 -9 plugins/reporting/web/KoReportDesignerItemWeb.cpp M +0 -1 plugins/reporting/web/KoReportDesignerItemWeb.h http://commits.kde.org/calligra/67ca698da69f86ceac669821ba33a6b18576ef18
Git commit 01f94ba87af154351be55b88cca5c028c04860b2 by Wojciech Kosowicz. Committed on 04/03/2015 at 21:20. Pushed by wkosowicz into branch 'calligra/2.9'. Added keyboard shortcuts for copy/paste/cut/delete in Kexi reports Shortcuts were added so now it's possible to use standard shortcuts like for example: ctrl+c for copying report element FIXED-IN: 2.9.1 REVIEW: 119368 M +12 -0 kexi/plugins/reports/kexireportdesignview.cpp M +1 -3 libs/koreport/wrtembed/KoReportDesigner.cpp http://commits.kde.org/calligra/01f94ba87af154351be55b88cca5c028c04860b2