Bug 334285 - Equality operators for NetworkLink and NetworkLinkControl
Summary: Equality operators for NetworkLink and NetworkLinkControl
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 1.7 (KDE 4.12)
Platform: unspecified Linux
: NOR task
Target Milestone: ---
Assignee: Cruceru Calin-Cristian
URL:
Keywords: junior-jobs
Depends on: 334276
Blocks: 334286
  Show dependency tree / graph
 
Reported: 2014-05-03 15:53 UTC by Dennis Nienhüser
Modified: 2014-05-04 14:16 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/marble/b089db28909c069be12e4915c7a4c5bf044eed36
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nienhüser 2014-05-03 15:53:05 UTC 
Add operator== and operator!= to the classes GeoDataNetworkLink and GeoDataNetworkLinkControl. Make sure to include a call to the equals() method of GeoDataFeature in the implementation. The check for equality of m_abstractView in GeoDataNetworkLinkControl should be done just like GeoDataFeature does (see the description in bug 334276).

Extend TestEquality for new unit test methods for GeoDataNetworkLink and GeoDataNetworkLinkControl instances. Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and run the test case from the build folder (run tests/TestEquality). Submit a review request at https://git.reviewboard.kde.org.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.
Comment 1 Cruceru Calin-Cristian 2014-05-03 22:48:29 UTC 
I want to work on this task. I already finished solving the bug this bug depends on (https://bugs.kde.org/show_bug.cgi?id=334276) and I will like to solve this too.