Bug 334019 - Okular should warn if closing with multiple tabs opened
Summary: Okular should warn if closing with multiple tabs opened
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
: 346642 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-04-28 12:49 UTC by zellox
Modified: 2022-02-18 07:56 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Patch file (1.48 KB, patch)
2015-12-04 00:42 UTC, torhamzed
Details
dialog (7.74 KB, image/png)
2015-12-04 00:43 UTC, torhamzed
Details
Git diff (1.62 KB, patch)
2015-12-17 20:37 UTC, torhamzed
Details

Note You need to log in before you can comment on or make changes to this bug.
Description zellox 2014-04-28 12:49:11 UTC
There should be a setting to make Okular warn the user (e.g. a dialog box which asks if you really want to close Okular) if multiple tabs are opened. This is present in other tabbed-based PDF viewers and would stop accidental closing of non-active tabs.
Comment 1 Albert Astals Cid 2014-04-28 19:47:53 UTC
Personally i am not sure that feature makes sense but if someone wants to implement it (not with a setting, just with a kmessagebox + don't ask me again) we can discuss about it.
Comment 2 Jonathan Doman 2014-04-29 00:11:05 UTC
I'm happy to implement this, but it may be a month before I have time to do it.
Comment 3 zellox 2014-04-29 01:54:36 UTC
Sounds good to me. It's not a huge issue any way, just a minor annoyance.
Comment 4 zellox 2014-05-01 06:40:59 UTC
"Personally i am not sure that feature makes sense but if someone wants to implement it" 
I just looked at dolphin and it has the same feature. Obviously it made sense to someone to implement. 
This might make it easier to add to Okular.
Comment 5 zellox 2015-01-07 02:13:15 UTC
Any update on this?
Comment 6 Albert Astals Cid 2015-07-28 13:04:30 UTC
*** Bug 346642 has been marked as a duplicate of this bug. ***
Comment 7 torhamzed 2015-12-04 00:41:25 UTC
Albert,

After a few of our discussions in IRC, here is a basic first attempt at completing this.  The 'no' button is the default selection.

Screenshot and diff enclosed.
Comment 8 torhamzed 2015-12-04 00:42:15 UTC
Created attachment 95886 [details]
Patch file
Comment 9 torhamzed 2015-12-04 00:43:58 UTC
Created attachment 95887 [details]
dialog
Comment 10 Albert Astals Cid 2015-12-05 11:42:57 UTC
Please use reviewboard.kde.org for the patch
Comment 11 torhamzed 2015-12-17 20:37:19 UTC
Created attachment 96157 [details]
Git diff
Comment 12 Albert Astals Cid 2015-12-17 23:09:09 UTC
What do you not understand of "Please use reviewboard.kde.org for the patch"?
Comment 13 torhamzed 2015-12-17 23:14:04 UTC
I added it to reviewboard before adding it here.  I apologize, is this KDE bug tracking website deprecated?  I've seen the use of both such type websites before, and that was how I saw them used - make sure a copy is in both places.
Comment 14 Albert Astals Cid 2015-12-19 16:24:33 UTC
(In reply to torhamzed from comment #13)
> I added it to reviewboard before adding it here.

I don't see it here https://git.reviewboard.kde.org/dashboard/?group=okular&view=to-group

>  I apologize, is this KDE bug tracking website deprecated?  

No, the bug tracking website is used to track bugs, not patches.

> I've seen the use of both such type
> websites before, and that was how I saw them used - make sure a copy is in
> both places.

Having things in more than one place is a bad practice, it's the perfect way to get things that only some people from one place read and only some other in some other and you end up with lots of lost communication.
Comment 15 Albert Astals Cid 2017-09-17 21:51:34 UTC
https://phabricator.kde.org/D7714
Comment 16 Jonas 2020-08-29 21:01:10 UTC
I think there should also be an option in settings. Otherwise, how do I get the confirmation dialog back once I have clicked "Don't ask me again"? (For now, could anybody tell me what to add/delete in which config file to get the dialog back?)
Comment 17 zellox 2022-02-18 07:56:46 UTC
This has been fixed for a while. Closing