Bug 333118 - Equality operators for style related classes
Summary: Equality operators for style related classes
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 1.8 (KDE 4.13)
Platform: unspecified Linux
: NOR task
Target Milestone: ---
Assignee: Abhinav Gangwar
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-04-06 08:50 UTC by Dennis Nienhüser
Modified: 2014-04-09 20:32 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/marble/74019695ff9b55160982ddc39b81ce61ff4591e3
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nienhüser 2014-04-06 08:50:40 UTC 
Add operator== and operator!= to the classes GeoDataIconStyle, GeoDataLineStyle, GeoDataListStyle, GeoDataPolyStyle, GeoDataStyle and GeoDataStyleMap. Extend TestEquality by a new unit test method for each class which verifies the implementation for several instances of each class.

Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and run the test case from the build folder (run tests/TestEquality). Note that operator!= should call operator==, see GeoDataAccuracy for an example. Submit a review request at https://git.reviewboard.kde.org.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.
Comment 1 Abhinav Gangwar 2014-04-06 08:59:53 UTC 
I would like to work on  this task
Comment 2 Dennis Nienhüser 2014-04-09 20:32:40 UTC 
Git commit 74019695ff9b55160982ddc39b81ce61ff4591e3 by Dennis Nienhüser, on behalf of Abhinav Gangwar.
Committed on 09/04/2014 at 20:31.
Pushed by nienhueser into branch 'master'.

Equality operators for style related classes

REVIEW: 117438

M  +18   -0    src/lib/marble/geodata/data/GeoDataIconStyle.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataIconStyle.h
M  +13   -0    src/lib/marble/geodata/data/GeoDataLabelStyle.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataLabelStyle.h
M  +19   -0    src/lib/marble/geodata/data/GeoDataLineStyle.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataLineStyle.h
M  +29   -0    src/lib/marble/geodata/data/GeoDataListStyle.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataListStyle.h
M  +16   -0    src/lib/marble/geodata/data/GeoDataPolyStyle.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataPolyStyle.h
M  +19   -0    src/lib/marble/geodata/data/GeoDataStyle.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataStyle.h
M  +16   -0    src/lib/marble/geodata/data/GeoDataStyleMap.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataStyleMap.h
M  +13   -0    src/lib/marble/geodata/data/GeoDataStyleSelector.cpp
M  +3    -0    src/lib/marble/geodata/data/GeoDataStyleSelector.h
M  +305  -0    tests/TestEquality.cpp
M  +13   -9    tests/TestGeoDataCopy.cpp

http://commits.kde.org/marble/74019695ff9b55160982ddc39b81ce61ff4591e3