Bug 333023 - Closing multiple tabs warning
Summary: Closing multiple tabs warning
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Martin Sandsmark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-03 13:43 UTC by Volkan
Modified: 2016-08-29 19:42 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Previous dialog in former versions of Konsole (48.57 KB, image/png)
2014-04-03 13:46 UTC, Volkan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Volkan 2014-04-03 13:43:13 UTC
If we have have multiple tabs open, closing them without any warning causes the current working directories forgotten and this is really annoying.

I would rather see that dialog with a "dont show checkbox" again.

Reproducible: Always

Steps to Reproduce:
1. Open at least two Konsole tabs
2. Close using X.
3.
Actual Results:  
It just quits without confirmation

Expected Results:  
It should show a confirmation to avoid losing current working directories.

This was possible in KDE version 4.11.5 (Konsole 2.8.5), but it has been removed as I learnt from the discussion:

https://bugs.kde.org/show_bug.cgi?id=331474#c10
Comment 1 Volkan 2014-04-03 13:46:11 UTC
Created attachment 85937 [details]
Previous dialog in former versions of Konsole
Comment 2 smalldickbigego 2014-06-15 00:12:40 UTC
I can confirm this one.
Quite annoying when using a dedicated mouse button for closing windows while having erroneously konsole window with multiple tabs active.
Comment 3 deviatov 2016-08-12 17:18:35 UTC
For me, is issue is also very annoying. I lose current directories as well as connection with the terminal of programs running "in detached mode", and the character encoding settings.
Comment 4 Martin Sandsmark 2016-08-13 12:12:24 UTC
https://git.reviewboard.kde.org/r/128668/ re-adds the dialog, shown in case there are no processes open but still open background tabs. It has the "do not ask again" checkbox, which is independent of the open processes dialog (i. e. you can select to ignore either one).
Comment 5 Martin Sandsmark 2016-08-28 22:10:13 UTC
Git commit e21fc13c473cff47654f02b1e5ecd6ff8e3636f4 by Martin T. H. Sandsmark.
Committed on 28/08/2016 at 22:10.
Pushed by sandsmark into branch 'master'.

Warn when trying to close window with open tabs

REVIEW: 128668

M  +29   -11   src/MainWindow.cpp

http://commits.kde.org/konsole/e21fc13c473cff47654f02b1e5ecd6ff8e3636f4