This task is about implementing full support for the KML extrude tag. It can occur as a child element of <Point>, <Polygon>, <LineString> and <LinearRing>. See https://developers.google.com/kml/documentation/kmlreference for details. - Fix KmlextrudeTagHandler::parse, which does a faulty boolean check if( parentItem.nodeAs<GeoDataGeometry>() ). Change both checks in that area to use parentItem.is<GeoData...>() for all fours elements (GeoDataPoint, GeoDataLineString, GeoDataLinearRing, GeoDataPolygon). Assign them the extrude value as necessary. - Extend all Kml*TagWriter.cpp files for Point, LineString, LinearRing and Polygon to write the extrude tag if extrude is active (so either <extrude>1</extrude> ends up in the KML file or nothing). - Extend the .kml files in tests/data/ to have at least one instance with <extrude>1</extrude> for all four tags Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Execute tests/TestGeoDataWriter and make sure no errors come up. Use tools/kml2kml to analyze errors and fix the tag writers, if needed. Submit a review request at https://git.reviewboard.kde.org with the marble group as reviewers. Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.
https://git.reviewboard.kde.org/r/117459/
Git commit c992fd62015f3c0e8725ad2117aad41054735377 by Dennis Nienhüser, on behalf of Marek Hakala. Committed on 09/04/2014 at 20:41. Pushed by nienhueser into branch 'master'. Fix and extend handling the KML extrude tag REVIEW: 117459 M +18 -8 src/lib/marble/geodata/handlers/kml/KmlExtrudeTagHandler.cpp M +2 -0 src/lib/marble/geodata/writers/kml/KmlLineStringTagWriter.cpp M +2 -0 src/lib/marble/geodata/writers/kml/KmlLinearRingTagWriter.cpp M +2 -1 src/lib/marble/geodata/writers/kml/KmlPointTagWriter.cpp M +2 -0 src/lib/marble/geodata/writers/kml/KmlPolygonTagWriter.cpp M +4 -0 tests/data/Geometries.kml http://commits.kde.org/marble/c992fd62015f3c0e8725ad2117aad41054735377