Bug 332108 - Read/write gx:altitudeMode for KML LookAt tags
Summary: Read/write gx:altitudeMode for KML LookAt tags
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 1.7 (KDE 4.12)
Platform: unspecified Linux
: NOR task
Target Milestone: ---
Assignee: Cruceru Calin-Cristian
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-03-13 20:05 UTC by Dennis Nienhüser
Modified: 2014-03-17 20:20 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nienhüser 2014-03-13 20:05:40 UTC
The gx:altitudeMode should be read from and written to KML files inside the LookAt tag. See https://developers.google.com/kml/documentation/kmlreference?#lookat
- Move the altitudeMode getter and setter from GeoDataCamera up to GeoDataAbstractView
- Change KmlaltitudeModeTagHandler to check for GeoDataAbstractView instead of GeoDataCamera
- Write the altitude mode in KmlLookAtTagWriter just like KmlCameraTagWriter does
- Add a <gx:altitudeMode>clampToSeaFloor</gx:altitudeMode> to tests/data/LookAtTest.kml

Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Execute tests/TestGeoDataWriter and make sure no errors come up. Use tools/kml2kml to analyze errors and fix the tag writers, if needed. Submit a review request at https://git.reviewboard.kde.org with the marble group as reviewers.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.
Comment 1 Cruceru Calin-Cristian 2014-03-13 21:40:11 UTC
I want to work on this task.
Comment 2 Dennis Nienhüser 2014-03-17 20:20:21 UTC
Git commit 6f665f734f4bd21933398680ef2aa7dbec0bd144 by Dennis Nienhüser, on behalf of Cruceru Calin-Cristian.
Committed on 17/03/2014 at 20:19.
Pushed by nienhueser into branch 'master'.

Read/write gx:altitudeMode for KML LookAt tags
REVIEW: 116831

M  +23   -2    src/lib/marble/geodata/data/GeoDataAbstractView.cpp
M  +5    -0    src/lib/marble/geodata/data/GeoDataAbstractView.h
M  +1    -12   src/lib/marble/geodata/data/GeoDataCamera.cpp
M  +0    -4    src/lib/marble/geodata/data/GeoDataCamera.h
M  +0    -2    src/lib/marble/geodata/data/GeoDataCamera_p.h
M  +3    -3    src/lib/marble/geodata/handlers/kml/KmlAltitudeModeTagHandler.cpp
M  +3    -3    src/lib/marble/geodata/handlers/kml/KmlGxAltitudeModeTagHandler.cpp
M  +2    -0    src/lib/marble/geodata/writers/kml/KmlLookAtTagWriter.cpp
M  +1    -0    tests/data/LookAtTest.kml

http://commits.kde.org/marble/6f665f734f4bd21933398680ef2aa7dbec0bd144