The "open documents in new tabs" setting doesn't have any effect, new documents are still opened in new windows Using KDE 4.13 beta 1 Reproducible: Always
Can you clarify the actions you are taking to reproduce and what is the expected behavior? New tabs will only be created for documents opened through okular's file open dialog. Documents opened through an external file browser or command line will open a new window. If this isn't the behavior you want/expect, you should resubmit this as a feature request and I can make a patch.
OK changed to wishlist then... I expected this to work for files open from the file browser (after all, that is how okular is usually opened)
Okay, I'm not an official developer but I'll try to implement this and get it reviewed. How would you expect this to behave when there are multiple okular windows already opened? Should it open a new tab in the first window, or any window, or a window determined by some other metric? (I have my own opinion but would like more inputs.)
If this is implemented I don't plan to have more than one okular window open ever, so I don't really mind. What do browsers usually do?
The fact that you don't plan any more than one okular ever open doesn't mean that it can't happen, so it's something that needs to be taken into account ;-)
Git commit 89fd56c23bc19812d3514991a6eeb9f27c2cb742 by Albert Astals Cid, on behalf of Jonathan Doman. Committed on 09/04/2014 at 21:29. Pushed by aacid into branch 'KDE/4.13'. Launch documents from external sources in new tabs FIXED-IN: 4.13.0 Related: bug 332238 REVIEW: 116700 M +12 -2 part.cpp M +2 -0 part.h M +85 -11 shell/main.cpp M +62 -9 shell/shell.cpp M +5 -0 shell/shell.h M +2 -23 ui/pageview.cpp M +0 -7 ui/pageview.h M +13 -0 ui/sidebar.cpp M +8 -0 ui/sidebar.h M +0 -17 ui/thumbnaillist.cpp M +0 -6 ui/thumbnaillist.h http://commits.kde.org/okular/89fd56c23bc19812d3514991a6eeb9f27c2cb742