Bug 331602 - Unit test for parsing/writing LatLonAltBox, LatLonBox, LineString, LinearRing, MultiGeometry
Summary: Unit test for parsing/writing LatLonAltBox, LatLonBox, LineString, LinearRing...
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 1.8 (KDE 4.13)
Platform: unspecified Linux
: NOR task
Target Milestone: ---
Assignee: Cruceru Calin-Cristian
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-02-28 09:05 UTC by Dennis Nienhüser
Modified: 2014-03-02 18:59 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nienhüser 2014-02-28 09:05:49 UTC
Add a KML file tests/data/Geometries.kml and include it in TestGeoDataWriter.cpp. The KML file should have several instances of LatLonAltBox, LatLonBox, LatLonQuad, LineString, LinearRing, MultiGeometry, possibly inside Placemarks in a Folder. The KML should be written to get a high coverage of the corresponding writers in http://nienhueser.de/marble/lcov/sources/src/lib/marble/geodata/writers/kml/index.html

Build Marble with unit tests enabled and verify that tests/TestGeoDataWriter still succeeds. If not, use the kml2kml tool to check for differences and fix the writer classes accordingly.

Make sure to compile Marble with the following cmake options enabled: BUILD_MARBLE_TESTS=TRUE, BUILD_MARBLE_TOOLS=TRUE. Submit a review request at https://git.reviewboard.kde.org with the marble groups as reviewers.

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.
Comment 1 Cruceru Calin-Cristian 2014-02-28 10:30:48 UTC
I want to work on this task.
Comment 2 Dennis Nienhüser 2014-03-02 18:59:09 UTC
Git commit 364cb88d60f103b429758e5cd27066f026e6fdd3 by Dennis Nienhüser, on behalf of Cruceru Calin-Cristian.
Committed on 02/03/2014 at 18:58.
Pushed by nienhueser into branch 'master'.

KML unit test for LatLon(Alt)Box, LineString, LinearRing, MultiGeometry
REVIEW: 116535

A  +116  -0    tests/data/Geometries.kml

http://commits.kde.org/marble/364cb88d60f103b429758e5cd27066f026e6fdd3