Bug 331587 - Equality operators for GeoDataFlyTo, GeoDataHotSpot, GeoDataImagePyramid, GeoDataItemIcon and GeoDataLink
Summary: Equality operators for GeoDataFlyTo, GeoDataHotSpot, GeoDataImagePyramid, Geo...
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 1.7 (KDE 4.12)
Platform: unspecified Linux
: NOR task
Target Milestone: ---
Assignee: Sanjiban Bairagya
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-02-27 21:58 UTC by Dennis Nienhüser
Modified: 2014-02-28 21:19 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nienhüser 2014-02-27 21:58:12 UTC
Add equality operators for the classes GeoDataFlyTo, GeoDataHotSpot, GeoDataImagePyramid, GeoDataItemIcon and GeoDataLink. Extend tests/TestEquality by a new unit test method for each of the classes which verifies the implementation for several instances of each class.

Make sure to compile Marble with the BUILD_MARBLE_TESTS=TRUE option enabled and run the test case from the build folder (run tests/TestEquality). Note that operator!= should call operator==, see GeoDataAccuracy for an example.

Submit a review request at https://git.reviewboard.kde.org

Please leave a comment here (e.g. "I want to work on this task.") if you start working on this task to avoid multiple people working on it at the same time.
Comment 1 Sanjiban Bairagya 2014-02-28 03:33:02 UTC
I want to work on this task.
Comment 2 Dennis Nienhüser 2014-02-28 21:19:57 UTC
Git commit 0c84eb2defc38a04effdc16ee744d70d358752b5 by Dennis Nienhüser, on behalf of Sanjiban Bairagya.
Committed on 28/02/2014 at 21:18.
Pushed by nienhueser into branch 'master'.

Equality operators for FlyTo, HotSpot, ImagePyramid, ItemIcon, Link.

REVIEW: 116485

M  +10   -0    src/lib/marble/geodata/data/GeoDataFlyTo.cpp
M  +3    -1    src/lib/marble/geodata/data/GeoDataFlyTo.h
M  +10   -0    src/lib/marble/geodata/data/GeoDataHotSpot.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataHotSpot.h
M  +10   -0    src/lib/marble/geodata/data/GeoDataImagePyramid.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataImagePyramid.h
M  +10   -0    src/lib/marble/geodata/data/GeoDataItemIcon.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataItemIcon.h
M  +11   -7    src/lib/marble/geodata/data/GeoDataLink.cpp
M  +2    -0    src/lib/marble/geodata/data/GeoDataLink.h
M  +107  -0    tests/TestEquality.cpp

http://commits.kde.org/marble/0c84eb2defc38a04effdc16ee744d70d358752b5