Bug 331375 - Please use the colored Amarok logo, not the monochrome one
Summary: Please use the colored Amarok logo, not the monochrome one
Status: RESOLVED FIXED
Alias: None
Product: muon
Classification: Applications
Component: discover (show other bugs)
Version: 2.1.3
Platform: Kubuntu Linux
: NOR minor
Target Milestone: ---
Assignee: Jonathan Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-21 11:35 UTC by Myriam Schweingruber
Modified: 2014-02-28 20:51 UTC (History)
2 users (show)

See Also:
Latest Commit: http://commits.kde.org/muon/e582c6ae489916640a38d44443489b68ae5fd9bd
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Myriam Schweingruber 2014-02-21 11:35:24 UTC 
Apparently Muon discover uses the monochrome systray icon instead of the official Amarok logo.  Please use the Amarok logo as provided by Amarok instead
Comment 1 Harald Sitter 2014-02-21 11:39:00 UTC 
Might be that the plasma icon cache interfers with icon loading.
Comment 2 Aleix Pol 2014-02-21 12:02:27 UTC 
Plasma Components always use the system tray variant. I'll see if I can fix it, I'm unsure.
Comment 3 Myriam Schweingruber 2014-02-21 12:17:54 UTC 
Well, when you search in the list below you get the correct blue log, only when you click on the information the top shows the monochrome one. Believe me, as a showcase for a new user we (the Amarok Team) really would want to see the correct logo there.
Comment 4 Aleix Pol 2014-02-28 15:24:24 UTC 
Git commit e582c6ae489916640a38d44443489b68ae5fd9bd by Aleix Pol.
Committed on 28/02/2014 at 14:28.
Pushed by apol into branch '2.2'.

Use QIconItem instead of PlasmaCore.IconItem

This way Plasma won't get the system tray icons but the system ones,
which is the ones we're looking for.

M  +2    -2    discover/qml/ApplicationOverview.qml
M  +5    -4    discover/qml/ApplicationsList.qml
M  +3    -2    discover/qml/ApplicationsTop.qml
M  +3    -2    discover/qml/CategoryHeader.qml
M  +3    -2    discover/qml/CategoryPage.qml
M  +3    -2    discover/qml/DefaultBanner.qml
M  +3    -2    discover/qml/FeaturedBanner.qml
M  +3    -2    discover/qml/MuonToolButton.qml
M  +2    -1    discover/qml/ProgressView.qml
M  +3    -2    discover/qml/Rating.qml

http://commits.kde.org/muon/e582c6ae489916640a38d44443489b68ae5fd9bd
Comment 5 Myriam Schweingruber 2014-02-28 20:51:07 UTC 
Wow, thanks a lot for fixing this so fast, you rock!