This task is about improving the code style in src/apps/marble-qt/QtMainWindow.h and rc/apps/marble-qt/QtMainWindow.cpp. Do the following changes: - Change variable name abbreviations: "Act" becomes "Action", e.g. m_copyMapAct becomes m_copyMapAction. Hint: Use QtCreator and its rename function (Ctrl+Shift+R) - Make sure MainWindow::MainWindow() initializes all pointers to 0, e.g. add m_copyMapAction( 0 ) Create a review request at https://git.reviewboard.kde.org with your patch. Use marble as reviewers group.
Created attachment 85263 [details] Attached a patch with the above mentioned changes. I have attached a patch with the two changes mentioned above. Please do review.
Created attachment 85268 [details] Patch for QtMainWindow coding style improvements
I also posted it here https://git.reviewboard.kde.org/r/115945/ . Sorry for those many updates. I forgot to update to your corrections from bug 331304 and then didn't commit the changes. Please review.
Assigning to Calin now as noted in https://git.reviewboard.kde.org/r/115938/
Git commit a0a4fc484ff3b9d967edabad0df882f70e97ef4f by Dennis Nienhüser, on behalf of Cruceru Calin-Cristian. Committed on 05/03/2014 at 16:50. Pushed by nienhueser into branch 'master'. Code style fixes REVIEW: 115945 M +194 -138 src/apps/marble-qt/QtMainWindow.cpp M +26 -26 src/apps/marble-qt/QtMainWindow.h http://commits.kde.org/marble/a0a4fc484ff3b9d967edabad0df882f70e97ef4f