Bug 331369 - Code style fixes in QtMainWindow
Summary: Code style fixes in QtMainWindow
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: 1.8 (KDE 4.13)
Platform: unspecified Linux
: NOR task
Target Milestone: ---
Assignee: Cruceru Calin-Cristian
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2014-02-21 09:44 UTC by Dennis Nienhüser
Modified: 2014-03-05 16:55 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Attached a patch with the above mentioned changes. (27.76 KB, patch)
2014-02-21 15:55 UTC, Savita
Details
Patch for QtMainWindow coding style improvements (31.23 KB, patch)
2014-02-21 21:48 UTC, Cruceru Calin-Cristian
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Nienhüser 2014-02-21 09:44:55 UTC
This task is about improving the code style in src/apps/marble-qt/QtMainWindow.h and rc/apps/marble-qt/QtMainWindow.cpp. Do the following changes:
- Change variable name abbreviations: "Act" becomes "Action", e.g. m_copyMapAct becomes m_copyMapAction. Hint: Use QtCreator and its rename function (Ctrl+Shift+R)
- Make sure MainWindow::MainWindow() initializes all pointers to 0, e.g. add m_copyMapAction( 0 )

Create a review request at https://git.reviewboard.kde.org with your patch. Use marble as reviewers group.
Comment 1 Savita 2014-02-21 15:55:07 UTC
Created attachment 85263 [details]
Attached a patch with the above mentioned changes.

I have attached a patch with the two changes mentioned above. Please do review.
Comment 2 Cruceru Calin-Cristian 2014-02-21 21:48:58 UTC
Created attachment 85268 [details]
Patch for QtMainWindow coding style improvements
Comment 3 Cruceru Calin-Cristian 2014-02-21 22:05:27 UTC
I also posted it here https://git.reviewboard.kde.org/r/115945/ .
Sorry for those many updates. I forgot to update to your corrections from bug 331304 and then didn't commit the changes.  

Please review.
Comment 4 Dennis Nienhüser 2014-03-05 16:48:45 UTC
Assigning to Calin now as noted in https://git.reviewboard.kde.org/r/115938/
Comment 5 Dennis Nienhüser 2014-03-05 16:55:05 UTC
Git commit a0a4fc484ff3b9d967edabad0df882f70e97ef4f by Dennis Nienhüser, on behalf of Cruceru Calin-Cristian.
Committed on 05/03/2014 at 16:50.
Pushed by nienhueser into branch 'master'.

Code style fixes

REVIEW: 115945

M  +194  -138  src/apps/marble-qt/QtMainWindow.cpp
M  +26   -26   src/apps/marble-qt/QtMainWindow.h

http://commits.kde.org/marble/a0a4fc484ff3b9d967edabad0df882f70e97ef4f