Bug 330199 - Crash after quick strokes with large custom brush when cursor is set to Brush Outline
Summary: Crash after quick strokes with large custom brush when cursor is set to Brush...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-20 12:25 UTC by Chris Jones
Modified: 2014-01-28 10:30 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Jones 2014-01-20 12:25:09 UTC
If Cursor Shape is set to Brush Outline, crashing results when using a preset with a large custom brush image (eg 1234 x 823), and touching the tablet briefly.  This generally does not happen when drawing a longer stroke or when using other cursor shapes, although it might explain less frequent, seemingly random crashes that can occur when touching pen to tablet.

It is more easily reproducible when using a tablet (Wacom Intuos 2 in my case), especially when tapping repeatedly, but can be achieved with a mouse as well.

Steps:
1.  Select and copy a decent sized image, say around 1000 pixels square (or more)
2.  Open Edit Brush Settings and select the Clipboard Brush tab
3.  Go back to the canvas and draw quick dabs, or click mouse button rapidly

Beta 2 (2.7.9.5), Win 8.1 64 Bit
Comment 1 Chris Jones 2014-01-20 12:30:15 UTC
Left out a step:  make sure Cursor shape is set to Brush Outline before drawing
Comment 2 Dmitry Kazakov 2014-01-24 08:33:03 UTC
Git commit 791e7441181a31ebd33bf8385296201350a7d5ab by Dmitry Kazakov.
Committed on 24/01/2014 at 08:32.
Pushed by dkazakov into branch 'master'.

Fix the crash when using multihand tool with some complicated brushes

Right now the brush server returns the pointers to the brushes instead
of the copies of them, so when changing its parameters, the change is
shared among all their users. For now it is an acceptable behavior,
because even the Multihand Brush Tool uses the same brush for all the
"hands". But we should ensure that we don't reset internal state of
the brush when reloading it with the same config options.
Related: bug 330212, bug 330210

M  +17   -3    krita/plugins/paintops/libbrush/kis_gbr_brush.cpp
M  +3    -0    krita/plugins/paintops/libbrush/kis_predefined_brush_factory.cpp

http://commits.kde.org/calligra/791e7441181a31ebd33bf8385296201350a7d5ab
Comment 3 Dmitry Kazakov 2014-01-24 08:33:32 UTC
Git commit b8a3d81de72749c1736f18caf02f63a756b602c2 by Dmitry Kazakov.
Committed on 24/01/2014 at 08:32.
Pushed by dkazakov into branch 'calligra/2.8'.

Fix the crash when using multihand tool with some complicated brushes

Right now the brush server returns the pointers to the brushes instead
of the copies of them, so when changing its parameters, the change is
shared among all their users. For now it is an acceptable behavior,
because even the Multihand Brush Tool uses the same brush for all the
"hands". But we should ensure that we don't reset internal state of
the brush when reloading it with the same config options.
Related: bug 330212, bug 330210

M  +17   -3    krita/plugins/paintops/libbrush/kis_gbr_brush.cpp
M  +3    -0    krita/plugins/paintops/libbrush/kis_predefined_brush_factory.cpp

http://commits.kde.org/calligra/b8a3d81de72749c1736f18caf02f63a756b602c2
Comment 4 Dmitry Kazakov 2014-01-28 06:20:27 UTC
Hi, Chris!

We've created new builds of Krita, could you please check, whether this bug still persists?

32-bit:
http://heap.kogmbh.net/downloads/krita_x86_2.7.9.6.msi

64-bit:
http://heap.kogmbh.net/downloads/krita_x64_2.7.9.6.msi
Comment 5 Chris Jones 2014-01-28 09:16:46 UTC
Hi Dmitry,

Nice work - I've tested x64, and large brushes no longer consistently crash when using Brush Outline.

I also tested for a while using the Small Circle cursor shape, and there were still occasional crashes when touching pen to tablet, so perhaps that's unrelated to this particular bug.
Comment 6 Halla Rempt 2014-01-28 10:03:45 UTC
Probably...