Bug 330164 - Hardcoded + untranslatable percent sign in volumepopupbutton.cpp
Summary: Hardcoded + untranslatable percent sign in volumepopupbutton.cpp
Status: RESOLVED FIXED
Alias: None
Product: juk
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Scott Wheeler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-19 16:18 UTC by Burkhard Lück
Modified: 2014-02-25 08:42 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/juk/50b004f5638a3f6563f513f8b7a5390b32854e7f
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Burkhard Lück 2014-01-19 16:18:32 UTC 
volumepopupbutton.cpp:109:    
m_volumeLabel->setText( QString::number( int( newVolume * 100 ) ) + '%' );

Problem:
In german there has to be a space char between number + percent sign ("89 %") and other languages like Turkish have the percent sign as prefix before the number,
see https://bugs.kde.org/show_bug.cgi?id=330135

With the hard coded percent sign in volumepopupbutton.cpp:109 it is not possible to translate it properly in de, tr and probably many more languages.
Comment 1 Arnold Dumas 2014-02-25 08:42:49 UTC 
Git commit 50b004f5638a3f6563f513f8b7a5390b32854e7f by Arnold Dumas.
Committed on 25/02/2014 at 08:38.
Pushed by arnolddumas into branch 'master'.

Make the % symbol translatable in the volume popup button.
REVIEW: 116034

M  +1    -1    volumepopupbutton.cpp

http://commits.kde.org/juk/50b004f5638a3f6563f513f8b7a5390b32854e7f