Bug 330136 - Oxygen-gtk forces GNOME default icons instead of user settings.
Summary: Oxygen-gtk forces GNOME default icons instead of user settings.
Status: RESOLVED UPSTREAM
Alias: None
Product: Oxygen
Classification: Plasma
Component: gtk2-engine (show other bugs)
Version: 1.4.0
Platform: Debian stable Linux
: NOR major
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-18 20:57 UTC by JoseLuisT
Modified: 2014-01-21 03:35 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
How it should look and how looks in Openbox. (51.72 KB, image/jpeg)
2014-01-18 20:59 UTC, JoseLuisT
Details
How it looks in KDE, GNOME Icons, and they shouldn't be there. (49.62 KB, image/jpeg)
2014-01-18 21:00 UTC, JoseLuisT
Details
The settings in kde-config-gtk (59.26 KB, image/jpeg)
2014-01-18 21:01 UTC, JoseLuisT
Details
My gtkrc file. (421 bytes, application/octet-stream)
2014-01-18 21:04 UTC, JoseLuisT
Details
No icons. (37.66 KB, image/jpeg)
2014-01-19 06:01 UTC, JoseLuisT
Details
Oxygen-gtk compiled from git sources. (213.02 KB, image/jpeg)
2014-01-20 20:43 UTC, JoseLuisT
Details
How behaves outside KDE. (226.92 KB, image/jpeg)
2014-01-20 20:53 UTC, JoseLuisT
Details
PcmanFM-1.1.2 (52.59 KB, image/jpeg)
2014-01-20 21:37 UTC, JoseLuisT
Details
Faenza for Gnome Icon theme set. (205.28 KB, image/jpeg)
2014-01-21 02:16 UTC, JoseLuisT
Details

Note You need to log in before you can comment on or make changes to this bug.
Description JoseLuisT 2014-01-18 20:57:40 UTC
This problem only ocurrs when using GTK applications inside KDE, and when you have the gnome-icon-theme-full installed, by some sort of dependencies... 

The problem is whenever the icon theme (both normal and fallback) you have set on Systemsettings > Applications Appearance > GTK, whenever you have in your home .gtkrc files, inside KDE... it just ignores the configuration and shows you a very nice window with a perfect oxygen integration, but with gnome icons... and no consistency.

Reproducible: Always

Steps to Reproduce:
1. Make sure you have gnome-icon-theme-full installed. 
2. Install another icon theme both in /usr/share/icons and ~/.icons
3. Open kcm4shell kde-config-gtk 
4. Set your icon theme and fallback icon theme, both different than gnome. 
Actual Results:  
Oxygen theme with Gnome icon theme, invalid. 

Expected Results:  
Oxygen theme with the icons I chosen in kde-config-gtk. 

The version in Debian packages... 

aptitude show gtk2-engines-oxygen
Paquete: gtk2-engines-oxygen                     
Estado: instalado
Instalado automáticamente: no
Multi-Arch: same
Versión: 1.2.4-1
Prioridad: opcional
Sección: gnome
Desarrollador: Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>
Arquitectura: amd64
Tamaño sin comprimir: 1 500 k
Depende de: libc6 (>= 2.4), libcairo2 (>= 1.10.0), libgcc1 (>= 1:4.1.1), libgdk-pixbuf2.0-0 (>= 2.22.0), libglib2.0-0 (>=
            2.26.0), libgtk2.0-0 (>= 2.24.5-4), libpango1.0-0 (>= 1.18.0), libstdc++6 (>= 4.6), libx11-6
Predepende de: multiarch-support
Sugiere: kde-config-gtk-style
Rompe: gtk2-engines-oxygen (!= 1.2.4-1)
Reemplaza: gtk2-engines-oxygen (< 1.2.4-1)
Descripción: Oxygen widget theme for GTK+-based applications
 Oxygen-Gtk is a port of the Oxygen widget style to GTK+. 
 
 It ensures visual consistency between GTK+ and Qt-based applications running under KDE.
Página principal: https://projects.kde.org/projects/playground/artwork/oxygen-gtk

this only happens inside KDE, in openbox I cannot reproduce this issue only inside KDE. 
I tried with another theme "Clearlooks" for gtk2 applications and "Adwaita" for gtk3, another icon theme different than Gnome default and shows the correct icons.
Comment 1 JoseLuisT 2014-01-18 20:59:25 UTC
Created attachment 84720 [details]
How it should look and how looks in Openbox.
Comment 2 JoseLuisT 2014-01-18 21:00:28 UTC
Created attachment 84721 [details]
How it looks in KDE, GNOME Icons, and they shouldn't be there.
Comment 3 JoseLuisT 2014-01-18 21:01:22 UTC
Created attachment 84722 [details]
The settings in kde-config-gtk
Comment 4 JoseLuisT 2014-01-18 21:04:08 UTC
Created attachment 84723 [details]
My gtkrc file.

The file gtkrc-2.0-kde4 is just a soft link to the .gtkrc-2.0 in my home.
Comment 5 JoseLuisT 2014-01-19 06:01:34 UTC
Created attachment 84729 [details]
No icons.

I removed the gnome theme icon just to see what happens... and then surprise! KDE doesn't take any icon theme... why it doesn't take my  configurations?
Comment 6 Ruslan Kabatsayev 2014-01-19 06:41:17 UTC
Oxygen-gtk 1.2.4 is way too old. Please try using latest version, 1.4.1.
Comment 7 Hugo Pereira Da Costa 2014-01-19 18:56:25 UTC
@JoseLuisT
As advised by Russlan, please upgrade to oxygen-gtk2-1.4.1 as advised in comment 6 (there will be no fix whatsoever to the 1.2 versions any time: it is dead,, and the bug you report might have been fixed since then)

Oxygen-gtk do not use the setting from gtkrc to define icon theme (and therefore not the one from the kde-gtk-config module, which is third party code anyway). It uses the settings from kde config files directly. (systemsettings->application-appearance->icons).  

The fallback is indeed set to gnome internally and is also not read from gtkrc, because
- there is no 'icon theme fallback' equivalent in kde options
- it is a fallback that is supposed to *always* work on gtk, and thus a valid fallback to broken primary icon style, used for KDE (as seem to be the case in your situation)

So the question: what is your KDE icon theme. The 'real issue' in this bug report is likely that this primary theme is somehow not loaded properly in gtk. (let me guess: is it kfanzea ?)

Finally, I'm not quite sure what is "Please tell if this is not frustating, disappointing..." means ? Can you explain ? Not sure either what you intended to prove by removing the gnome icon theme (the obtained result seems to be the expected one) 

Best regards,

Hugo
Comment 8 JoseLuisT 2014-01-19 21:59:51 UTC
Sorry if this is bothering to you... but not everybody knows how the software works, and I thought I was apporting something to make this style better... I just found a failure and I reported properly.... 

But , thanks for the explanation I have more clear how the oxygen-gtk works, It was very clear your explanation.

Yes, my KDE theme is KFaenza.. I don't know if the theme have some issues that may be the cause of that behavior. 

Finally, what I tried to prove by removing the gnome-icon-theme was originated by my mis-conception of how oxygen-gtk handles the icons... Sorry for that attachment, I edited the description on it, but it should took the oxygen icons instead of nothing, shouldn't it? the oxygen theme is a valid fallback, isn't it?

I will try to upgrade, later but I can say that I don't have these issue in later versions, I use Opensuse 12.3 in another computer and oxygen-gtk works flawless.  

Thank you for your explanation, I will close this bug right now. 

Jose Luis.
Comment 9 Hugo Pereira Da Costa 2014-01-20 08:41:14 UTC
@Jose Luis
First reoppening the bug, because it is not yet proven that there is no issue on our (oxygen-gtk) side.

So far, using latest oxygen-gtk, (versions 1.4.1), and kfaenza icon theme under KDE, set with application appearance->icons, I am not able to reproduce the issue. See screenshot below (pcmanfm, which I think is also what you used for your screenshots):

http://wstaw.org/m/2014/01/20/plasma-desktopry5437.png

So definitly I'd be interested to know:
- how it looks on your side when you have upgraded to version 1.4 (you can try compile the sources directly, downloaded from oxygen-gtk @ KDE-look.org, its relatively simple)
- if (in case of failure) you use a different icon theme in your kde settings.

Best,

Hugo
Comment 10 Hugo Pereira Da Costa 2014-01-20 08:45:14 UTC
PS: concerning your questions
- for the use of kde-config-gtk, I know it is confusing, since this guy does work for any other gtk theme, (except also qtcurve, I think). Reason is that it came _after_ oxygen-gtk. At the time oxygen-gtk was out, there was no such (decently working) module, which is why we decided to read the kde settings directly instead of (hard to edit) .gtkrc-2.0 files. Qt-curve did the same choice.

- concerning using oxygen as a fallback icon theme, I agree that this would seem natural. unfortunately there are  non standard icon names (that is: not set in freedesktop.org specifications) defined in the gnome icon theme that are not implemented in oxygen, and nonetheless used by some gtk applications. Hence the choice we made. 
Besides, provided that the "primary" icon theme (and the theme from which it derives) is properly loaded, and complete, this should in principle make no difference ...
Comment 11 JoseLuisT 2014-01-20 20:41:32 UTC
Thank you Hugo, for your interest in help me, and may be others, this is great, and Yes I compiled no problem I used the sources from git, if that's correct.

So, I have the same results no icons at least on pacmanfm, I installed Thunar, and it has no problem, it shows the correct icons, as the attachment.
Comment 12 JoseLuisT 2014-01-20 20:43:27 UTC
Created attachment 84753 [details]
Oxygen-gtk compiled from git sources.

Thunar has no problem, pcmanfm does have the problem.
Comment 13 Hugo Pereira Da Costa 2014-01-20 20:45:45 UTC
(In reply to comment #11)
> Thank you Hugo, for your interest in help me, and may be others, this is
> great, and Yes I compiled no problem I used the sources from git, if that's
> correct.
> 
> So, I have the same results no icons at least on pacmanfm, I installed
> Thunar, and it has no problem, it shows the correct icons, as the attachment.

... so definitly something to do with the icon theme, rather than oxygen-gtk.
It is strange though that
- you can get things to work in openbox (but then, are you sure you are actually using the same icon theme :))
- I cannot reproduce (this might be due to a more recent version of gtk2. I use: 2.24.22)

In any case that is an upstream bug (either in gtk or in kfaenza, that has a non standard mapping of its icon path)

Did you try using Faenza directly (not the K version of it ?)
Comment 14 Hugo Pereira Da Costa 2014-01-20 20:47:31 UTC
oh. Your version of pcmanfm is quite older than mine too. Maybe that can cause the issue also.
I have 1.1.2
Comment 15 JoseLuisT 2014-01-20 20:53:09 UTC
I added another attachment, In openbox; in systemsettings>Application appereance > GTK I have: 

Icon Theme --> Faenza-Cupertino, this theme inherits contents from Original Faenza. 
Fallback Icon Theme --> Faenza, the original theme. in Openbox it seems to me that it takes the fallback, I don't know what really takes in this condition.
Comment 16 JoseLuisT 2014-01-20 20:53:57 UTC
Created attachment 84754 [details]
How behaves outside KDE.
Comment 17 JoseLuisT 2014-01-20 20:56:14 UTC
I will upgrade to the version you have of pcmanfm, if its possible of course, but the doubt I have, the version of pcmanfm you have uses gtk 2? 

I have OpenSuse 12.3 in another computer with KDE 4.10, but pcmanfm in that distribution uses gtk3.
Comment 18 Hugo Pereira Da Costa 2014-01-20 21:11:27 UTC
My version of pcmanfm definitly use gtk2
(but there might be ways to compile it to use gtk3, no clue)
Comment 19 JoseLuisT 2014-01-20 21:36:43 UTC
I add the attachment in which I use pcmanfm 1.1.2, unfortunately still the issue...
Comment 20 JoseLuisT 2014-01-20 21:37:23 UTC
Created attachment 84759 [details]
PcmanFM-1.1.2
Comment 21 JoseLuisT 2014-01-21 02:14:50 UTC
I found whats the issue, and it is not related with oxygen-gtk at all, it is the Kfaenza theme... I set the "Faenza-Cupertino" directly as the KDE icons in Systemsettings > Applications Appearance > Icons... 

They look correct in pcmanFM. 

I also set the Oxygen icons, they look correct as well.  

attachment above.
Comment 22 JoseLuisT 2014-01-21 02:16:51 UTC
Created attachment 84762 [details]
Faenza for Gnome Icon theme set.
Comment 23 JoseLuisT 2014-01-21 03:35:12 UTC
And I don't know if this is correct, but this comment is to thank you Hugo for your help, I finally solved the issue by my way... the problem was not definitively related to oxygen-gtk, or not so related, because pcmanfm was only the gtk application that showed the issue... there are other GTK apps with some relation, I have Inkscape, but instead showing me the kfaenza folders, in the open dialog, it showed me the gnome folders, after deleting the gnome iconset, it showed the oxygen folders instead. 

I took only just one symbolic link in /usr/share/icons that points to my home location of the KFaenza theme, in .kde/share/icons in my case. 

Thanks Hugo, for all you support and everybody else for taking seriously this humble bug report

Best regards. 

Jose Luis Triana.