Bug 330037 - Tweets marked favorite from Choqok are not listed on Favorite Folder
Summary: Tweets marked favorite from Choqok are not listed on Favorite Folder
Status: RESOLVED FIXED
Alias: None
Product: choqok
Classification: Applications
Component: Twitter (show other bugs)
Version: 1.4
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Daniel Kreuter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-16 15:12 UTC by Ricardo Chung
Modified: 2014-12-13 13:49 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.5
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ricardo Chung 2014-01-16 15:12:04 UTC
Tweet marked favorite from Choqok is not listed on the Choqok's Favorite Folder. It shows Favorite Mark highlighted.  

Tweet marked favorite from other twitter clients (e.g. smartphone, tablet) is listed on Choqok's Favorite Folder. It shows Favorite Mark highlighted.


Reproducible: Always

Steps to Reproduce:
1.On Choqok, select a tweet and mark Favorite
2.Browse into Choqok's Favorite Folder
3.Tweet marked Favorite is not showed
Actual Results:  
twitter.com doesn't show favorite marker from tweets marked in Chokoq.
Choqok shows favorite marker from tweets marked in Twitter or Twitter App.


Expected Results:  
Choqok used to show favorite marker and favorite tweets on Favorite Folder.

There is a similar bug on Choqok version 1.3 https://bugs.kde.org/show_bug.cgi?id=321328 focused only on Choqok missing feature. 

On Choqok version 1.4 it looks like it's only not able to send the Favorite Marker to the server.
Comment 1 Daniel Kreuter 2014-01-16 18:37:23 UTC
Hi,

by reading the peace of code responsible for the favorites I found the reason why it's not working. I will provide a fix later this day on reviewboard.

Best regards

Daniel
Comment 2 Daniel Kreuter 2014-01-16 21:25:20 UTC
Hi again,

patch is currently on reviewboard. Fixed creating of favorites as well as deleting them.

Best regards
Comment 3 Daniel Kreuter 2014-01-17 17:02:31 UTC
Git commit a93ae8bbd965d5e10c3088c8e94b1bc595037e48 by Daniel Kreuter.
Committed on 16/01/2014 at 21:15.
Pushed by dkreuter into branch 'master'.

Fixing twitter favorites.

Fixed creating / destroying of twitter favorite tweets.

M  +17   -10   helperlibs/twitterapihelper/twitterapimicroblog.cpp

http://commits.kde.org/choqok/a93ae8bbd965d5e10c3088c8e94b1bc595037e48
Comment 4 Daniel Kreuter 2014-01-17 17:03:14 UTC
Bugfix has been committed to the master branch --> closed.