Bug 329691 - "Edit > Fill With Foreground/Background colors" should not be influenced by user opacity (Slider)
Summary: "Edit > Fill With Foreground/Background colors" should not be influenced by u...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 2.8 Pre-Alpha
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-07 13:49 UTC by David REVOY
Modified: 2015-08-12 13:20 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2014-01-07 13:49:58 UTC
Hi, the feature "Edit > Fill With Foreground colors"(Shift+Backspace) and "Edit > Fill With Background colors"(backspace) got a bug ; they take in account the value on the opacity slider of the brush preset. They usually fill with plain color. 

To reproduce :
============
1) Open Krita, a canvas 
2) press  'D' to reset color to Black&White
3) Select a preset ( Airbrush )
4) Down the opacity with the slider to 50% 
5) Draw 2 or 3 strokes on canvas
6) Now press 'Backspace' to erase all (  Fill With Background colors = white ) 

Result :
======
You have to press  'Backspace' more than 10 times before the strokes disappears. 
It's like if "Fill With Background colors" was filling with 10% opacity pass the canvas.
If you undo all ; and redo all with 100% opacity , "Fill With Background colors" will work as expected. 

Expected result :
==============
"Edit > Fill With Foreground colors"(Shift+Backspace) and "Edit > Fill With Background colors"(backspace) should always use 100% opacity.
Comment 1 Halla Rempt 2014-01-07 14:45:17 UTC
Git commit f042f76bd7bff53feee8f1e62f126137cc427d89 by Boudewijn Rempt.
Committed on 07/01/2014 at 14:44.
Pushed by rempt into branch 'calligra/2.8'.

Bucket fill still uses the currently set opacity, but the shortcuts to
fill the entire layer with background or foreground colors should not
use the global opacity.

M  +1    -0    krita/ui/actions/kis_selection_action_factories.cpp
M  +5    -0    krita/ui/tool/kis_resources_snapshot.cpp
M  +1    -0    krita/ui/tool/kis_resources_snapshot.h

http://commits.kde.org/calligra/f042f76bd7bff53feee8f1e62f126137cc427d89
Comment 2 Halla Rempt 2014-01-07 14:45:17 UTC
Git commit c7c0906d7f00910aef894ce568e1a2c5011678de by Boudewijn Rempt.
Committed on 07/01/2014 at 14:44.
Pushed by rempt into branch 'master'.

Bucket fill still uses the currently set opacity, but the shortcuts to
fill the entire layer with background or foreground colors should not
use the global opacity.

M  +1    -0    krita/ui/actions/kis_selection_action_factories.cpp
M  +5    -0    krita/ui/tool/kis_resources_snapshot.cpp
M  +1    -0    krita/ui/tool/kis_resources_snapshot.h

http://commits.kde.org/calligra/c7c0906d7f00910aef894ce568e1a2c5011678de
Comment 3 Halla Rempt 2015-08-12 13:20:48 UTC
Git commit a0d213b2016d9e89d1504b708c28526a4f151019 by Boudewijn Rempt.
Committed on 12/08/2015 at 13:19.
Pushed by rempt into branch 'calligra/2.9'.
Related: bug 348742

Now we have both options: fill opaque, as in gimp and photoshop,
and fill with the current opacity, which we used to have. The
default shortcuts have Shift added to respect the current opacity.

M  +3    -1    krita/ui/actions/kis_selection_action_factories.cpp
M  +39   -1    krita/ui/kis_selection_manager.cc
M  +6    -0    krita/ui/kis_selection_manager.h

http://commits.kde.org/calligra/a0d213b2016d9e89d1504b708c28526a4f151019