Bug 328790 - Show comments in archives
Summary: Show comments in archives
Status: RESOLVED FIXED
Alias: None
Product: ark
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Ragnar Thomsen
URL:
Keywords:
: 348583 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-14 10:34 UTC by Aaron Lewis
Modified: 2015-10-26 23:50 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 15.12.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Lewis 2013-12-14 10:34:20 UTC
RAR could contain comments about this archive, it would be cool if it's visible in ARK

(So  are zip files)

Reproducible: Always
Comment 1 Raphael Kubo da Costa 2015-06-02 16:55:09 UTC
*** Bug 348583 has been marked as a duplicate of this bug. ***
Comment 2 Raphael Kubo da Costa 2015-06-02 16:55:38 UTC
Bug 348583 also mentions the possibility of adding/editing comments in the archives.
Comment 3 Ragnar Thomsen 2015-10-26 23:50:25 UTC
Git commit 3a22bbd5ecfe409023088aa3e71e3151cc442860 by Ragnar Thomsen.
Committed on 26/10/2015 at 23:47.
Pushed by rthomsen into branch 'master'.

Add support for reading archive comments

Add support for reading comments in CLI-based plugins such as rar and
zip. The comment is parsed from the output of ListJob. The comment is
displayed below the file view in a read-only QPlainTextEdit with
monospace font. A QSplitter is used so the user can resize the comment
field.

Support is added to clirar, clizip and cli7z plugins. The 7z-format
doesn't support comments, but the cli7z-plugin supports reading comments
in e.g. zip archives.
FIXED-IN: 15.12.0
REVIEW: 124468

M  +5    -0    kerfuffle/archive_kerfuffle.cpp
M  +2    -0    kerfuffle/archive_kerfuffle.h
M  +5    -0    kerfuffle/archiveinterface.cpp
M  +6    -1    kerfuffle/archiveinterface.h
M  +0    -1    kerfuffle/cliinterface.h
M  +35   -7    part/part.cpp
M  +5    -0    part/part.h
M  +20   -0    plugins/cli7zplugin/cliplugin.cpp
M  +2    -0    plugins/cli7zplugin/cliplugin.h
M  +1    -0    plugins/clilhaplugin/cliplugin.cpp
M  +0    -2    plugins/clirarplugin/cliplugin.h
M  +25   -1    plugins/clizipplugin/cliplugin.cpp
M  +3    -0    plugins/clizipplugin/cliplugin.h

http://commits.kde.org/ark/3a22bbd5ecfe409023088aa3e71e3151cc442860