Bug 327932 - Lame encoding quality is set by spinbox, but labels suggest slider
Summary: Lame encoding quality is set by spinbox, but labels suggest slider
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: Plugins (show other bugs)
Version: 2.0.2
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: ---
Assignee: Jeffery MacEachern
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-11-22 10:21 UTC by Jeffery MacEachern
Modified: 2013-11-25 23:32 UTC (History)
2 users (show)

See Also:
Latest Commit: 3955c88b72bc4781910c5d61b1d18b5d58bad2ff
Version Fixed In:
Sentry Crash Report:

Attachments
Image for clarity (39.68 KB, image/png)
2013-11-22 10:22 UTC, Jeffery MacEachern 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffery MacEachern 2013-11-22 10:21:17 UTC 
Just a usability issue.

Reproducible: Always

Steps to Reproduce:
1. Open Settings -> Plugins; select Configure button for Lame MP3 Encoder
2. Switch to Advanced tab
Actual Results:  
The Encoder Quality is set by a spinbox, but there are labels underneath ("fast encoding" / "high quality") on opposite sides.

Expected Results:  
Either the labels would be removed, since there is no mapping between them and the value in a spinbox, or the spinbox would be replaced with a slider as with the Quality Settings slider/labels in the main (Settings) tab of the dialog.
Comment 1 Jeffery MacEachern 2013-11-22 10:22:00 UTC 
Created attachment 83696 [details]
Image for clarity
Comment 2 Christoph Feck 2013-11-23 11:58:05 UTC 
Yep, there is code to enable the slider, but it is used wrong. Easy to fix, marking as a junior-job.
Comment 3 Jeffery MacEachern 2013-11-25 02:32:34 UTC 
This has been committed now as 3955c88b72bc4781910c5d61b1d18b5d58bad2ff. I didn't find out about the commit hook keywords until after. Sorry for the bother. Marking as Resolved now.
Comment 4 Christoph Feck 2013-11-25 23:32:47 UTC 
Thanks Jeffery. Please understand that k3b currently has no maintainer, so that no official release is to be expected to include your fix, unless someone steps up volunteering.