Bug 325481 - Wrap around mode should be greyed out if open gl canvas not used.
Summary: Wrap around mode should be greyed out if open gl canvas not used.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: git master (please specify the git hash!)
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-01 02:49 UTC by vanyossi
Modified: 2013-12-11 10:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description vanyossi 2013-10-01 02:49:47 UTC
The user gets the feeling something is broken as the checkbox does change if pressed

I thought krita was broken. Only after running from the terminal I realized something was missing

The message from stdout could be set in an alert box,  maybe?
Also I suggest to tweak the message to mention "opengl" as "Canvas type" definition is never used in the settings windows

Wrap Around mode is not available for this type of canvas!
to
Wrap Around mode only available with openGl enabled!

Reproducible: Always
Comment 1 Dmitry Kazakov 2013-11-04 14:33:34 UTC
Yes, a message box might be a good solution.
Comment 2 Halla Rempt 2013-12-11 10:30:51 UTC
Git commit 9d78753f50b5973f2773dd71ea0c239e7bb849ec by Boudewijn Rempt.
Committed on 11/12/2013 at 10:29.
Pushed by rempt into branch 'calligra/2.8'.

If the current canvas doesn't support opengl, wraparound painting will
work fine, but there won't be visual feedback. Warn the user
unobtrusively and remove the stdout feedback line.

M  +11   -2    krita/ui/canvas/kis_canvas_controller.cpp
M  +2    -1    krita/ui/canvas/kis_canvas_controller.h
M  +0    -1    krita/ui/canvas/kis_canvas_widget_base.cpp

http://commits.kde.org/calligra/9d78753f50b5973f2773dd71ea0c239e7bb849ec
Comment 3 Halla Rempt 2013-12-11 10:30:57 UTC
Git commit 943621e0acc8cea3997f012c7fdd635b1c9640bd by Boudewijn Rempt.
Committed on 11/12/2013 at 10:29.
Pushed by rempt into branch 'master'.

If the current canvas doesn't support opengl, wraparound painting will
work fine, but there won't be visual feedback. Warn the user
unobtrusively and remove the stdout feedback line.

M  +11   -2    krita/ui/canvas/kis_canvas_controller.cpp
M  +2    -1    krita/ui/canvas/kis_canvas_controller.h
M  +0    -1    krita/ui/canvas/kis_canvas_widget_base.cpp

http://commits.kde.org/calligra/943621e0acc8cea3997f012c7fdd635b1c9640bd