Bug 325393 - Changing the plugin in the filter dialog loses the vector selection
Summary: Changing the plugin in the filter dialog loses the vector selection
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: ui (show other bugs)
Version: 2.0.7
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-28 15:47 UTC by Nicolas Brisset
Modified: 2013-10-02 22:14 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Brisset 2013-09-28 15:47:49 UTC 
When using the filter entry in the plot context menu, changing the plugin in the filter dialog loses the vector selection.

Reproducible: Always

Steps to Reproduce:
1. Load 3 vectors from a data file and plot 3 curves
2. Go to the second plot
3. RMB -> Filter -> [Curve]
4. The y vector from the curve is preselected
5. Select the Fixed Step Differentiation plugin from the list: the vector changes
Actual Results:  
The selected vector changes to the first vector

Expected Results:  
The selected vector remains unchanged

Seems to be plugin-dependent: happens with Shift and Fixed Step. Probably something missing/wrong in those 2 plugins.
Comment 1 Nicolas Brisset 2013-09-29 19:30:54 UTC 
Fixed in git master with following commit (it seems bugzilla integration did not work, so I'm adding the link manually here):

  Branch: refs/heads/master
  Home:   https://github.com/Kst-plot/kst
  Commit: 63555295e1a76db0253a11d5b867e48930513dc0
      https://github.com/Kst-plot/kst/commit/63555295e1a76db0253a11d5b867e48930513dc0
  Author: Nicolas Brisset <nicolas.brisset@free.fr>
  Date:   2013-09-29 (Sun, 29 Sep 2013)

  Changed paths:
    M cmake/src/plugins/CMakeLists.txt
    R src/plugins/dataobject/differentiation/differentiation.cpp
    R src/plugins/dataobject/differentiation/differentiation.h
    R src/plugins/dataobject/differentiation/differentiation.pro
    R src/plugins/dataobject/differentiation/differentiationconfig.ui
    R src/plugins/dataobject/differentiation/kstplugin_differentiation.desktop
    M src/plugins/dataobject/shift/shift.cpp
    M src/plugins/dataobject/shift/shift.h
    M src/plugins/filters/differentiation/differentiation.cpp

  Log Message:
  -----------
  - Solve wrong vector selection in shift and differentiation plugins -> fix bug 325393
- Remove one copy of differentiation (dataobject) after merging the 2 slightly different ones - keep the one in filter/
I haven't (yet) changed the differentiation algorithm, that will come next.
Comment 2 Jekyll Wu 2013-09-29 21:56:01 UTC 
@Nicolas, use "BUG: 325393" in a separate line within your commit message. 

Also, you need to make sure the email address you use in git has corresponding user with enough permission in the bugzilla . In short, use nicolas.brisset@eurocopter.com .
Comment 3 Christoph Feck 2013-10-02 22:14:55 UTC 
Jekyll, kst is not hosted on KDE's infrastructure, so it does not matter :)