Bug 325164 - Please announce that dragonplayer understand isos
Summary: Please announce that dragonplayer understand isos
Status: RESOLVED FIXED
Alias: None
Product: dragonplayer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: Harald Sitter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-22 08:25 UTC by Petter Reinholdtsen
Modified: 2013-11-18 10:42 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.11.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petter Reinholdtsen 2013-09-22 08:25:05 UTC
The Debian bug <URL: http://bugs.debian.org/658612 > include a patch to allow
dragonplayer to announce its support for the application/x-cd-image mime type,
getting KDE to propose it when looking at DVD and CD ISO files.  Please consider
including it in the default setup.

The change needed is a simple entry to the /usr/share/applications/kde4/dragonplayer.desktop file.
Comment 1 Harald Sitter 2013-09-22 15:39:50 UTC
Please feel free to submit a patch http://techbase.kde.org/Development/Review_Board
Comment 2 Petter Reinholdtsen 2013-09-22 20:02:34 UTC
[Harald Sitter]
> Please feel free to submit a patch
> http://techbase.kde.org/Development/Review_Board

For those with that kind of time on their hands, a proposed patch is
available from the Debian bug tracker.
Comment 3 Maximiliano Curia 2013-11-15 08:57:56 UTC
Added a reviewboard request.
https://git.reviewboard.kde.org/r/113873/
Comment 4 Harald Sitter 2013-11-18 01:24:34 UTC
Git commit 0706b4df5aae5110be69d0ca78065b08cfdf359e by Harald Sitter.
Committed on 18/11/2013 at 01:24.
Pushed by sitter into branch 'KDE/4.12'.

Add application/x-cd-image to supported mime types

REVIEW: 113873
FIXED-IN: 4.12.0

M  +1    -1    misc/dragonplayer.desktop

http://commits.kde.org/dragon/0706b4df5aae5110be69d0ca78065b08cfdf359e
Comment 5 Maximiliano Curia 2013-11-18 10:07:40 UTC
(In reply to comment #4)
> Git commit 0706b4df5aae5110be69d0ca78065b08cfdf359e by Harald Sitter.
> Committed on 18/11/2013 at 01:24.
> Pushed by sitter into branch 'KDE/4.12'.
 
> Add application/x-cd-image to supported mime types
 
> REVIEW: 113873
> FIXED-IN: 4.12.0
 
> M  +1    -1    misc/dragonplayer.desktop
 
> http://commits.kde.org/dragon/0706b4df5aae5110be69d0ca78065b08cfdf359e

Could you commit this fix in the kde4.11 branch?

Thanks,
Comment 6 Harald Sitter 2013-11-18 10:41:48 UTC
Git commit 88bcb1f59baa98436d82ccd9952b415353ddb7dd by Harald Sitter.
Committed on 18/11/2013 at 10:41.
Pushed by sitter into branch 'KDE/4.11'.

Add application/x-cd-image to supported mime types

Since mimetypes incorrectly represent multimedia container and codec
support adding things is nigh regression free since their actual support
depends on gstreamer/vlc and their plugins.
FIXED-IN: 4.11.4

M  +1    -1    misc/dragonplayer.desktop

http://commits.kde.org/dragon/88bcb1f59baa98436d82ccd9952b415353ddb7dd