Bug 324785 - Filter mask auto-name to filter type
Summary: Filter mask auto-name to filter type
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: git master (please specify the git hash!)
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-11 12:22 UTC by Bollebib
Modified: 2013-09-28 10:00 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bollebib 2013-09-11 12:22:16 UTC
when you create a filter mask it gets genericly named "filter mask"


it would be handy to just make it mimick the chosen filter (brightness/contrast,adjust color, gaussian blur,etc)

it's not something crucial by any means,but it could save time.
Comment 1 Halla Rempt 2013-09-11 12:27:40 UTC
Good point!
Comment 2 Halla Rempt 2013-09-11 12:28:55 UTC
Weird though, the code already tries to do that.
Comment 3 Halla Rempt 2013-09-28 09:01:50 UTC
Hm -- and trying to set the mask name with the mask properties dialog fails as well.
Comment 4 Halla Rempt 2013-09-28 09:50:42 UTC
Git commit 5d1f29a504e4b2d6629711096569e12671f216fd by Boudewijn Rempt.
Committed on 28/09/2013 at 09:49.
Pushed by rempt into branch 'master'.

Add the filter name to the filter layer or filter mask name

This restores functionality written by Melchior Franz in 2006 which
unaccountably got lost in the mists of time... From the code, it looks
like blockSignals hadn't been invented back then, so it's also a small
cleanup

M  +22   -13   krita/ui/dialogs/kis_dlg_adjustment_layer.cc
M  +3    -2    krita/ui/dialogs/kis_dlg_adjustment_layer.h
M  +5    -0    krita/ui/widgets/kis_filter_selector_widget.cc
M  +1    -0    krita/ui/widgets/kis_filter_selector_widget.h

http://commits.kde.org/calligra/5d1f29a504e4b2d6629711096569e12671f216fd
Comment 5 Halla Rempt 2013-09-28 10:00:27 UTC
Git commit 09df33c3a2c1b18a77d470123df6e58f948815a7 by Boudewijn Rempt.
Committed on 28/09/2013 at 10:00.
Pushed by rempt into branch 'master'.

Set the filter mask name after editing properties

M  +1    -0    krita/ui/kis_mask_manager.cc

http://commits.kde.org/calligra/09df33c3a2c1b18a77d470123df6e58f948815a7