Bug 324763 - React to changes to UIDVALIDITY that happen while mailbox is selected
Summary: React to changes to UIDVALIDITY that happen while mailbox is selected
Status: RESOLVED FIXED
Alias: None
Product: trojita
Classification: Unmaintained
Component: IMAP (show other bugs)
Version: git
Platform: unspecified Linux
: NOR minor
Target Milestone: ---
Assignee: Trojita default assignee
URL: http://tools.ietf.org/html/rfc2683#pa...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-10 19:32 UTC by Jan Kundrát
Modified: 2013-10-08 06:27 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kundrát 2013-09-10 19:32:24 UTC
It's a non-issue in real world, but according to http://tools.ietf.org/html/rfc2683#page-13 , one shall deal with changed UIDVALIDITY while a mailbox is selected.

A completely acceptable fix would be to raise an error and disconnect.
Comment 1 Jan Kundrát 2013-10-08 06:27:43 UTC
Git commit 41e25fc28527aa528336039fa27fa89ef3d7e32c by Jan Kundrát.
Committed on 04/10/2013 at 19:53.
Pushed by jkt into branch 'master'.

IMAP: detect UIDVALIDITY changes when they happen while a mailbox is already selected

No real-world IMAP server shall do this, ever, and expect the clients to work
well. That said, clients absolutely have to handle this reasonably. Given that
no server is known to do this (apart from an old version which does this at most
once for a user for reasons related to delayed mailbox allocation), it seems
acceptable to simply disconnect in this case.

Yes, it might be possible to reconnect to the mailbox. However, verifying that
all pending requests are killed reasonably is too much work for a condition that
no Trojita user will ever see, hopefully.
REVIEW: 113109

M  +22   -0    src/Imap/Tasks/KeepMailboxOpenTask.cpp
M  +21   -0    tests/Imap/test_Imap_SelectedMailboxUpdates.cpp
M  +2    -0    tests/Imap/test_Imap_SelectedMailboxUpdates.h

http://commits.kde.org/trojita/41e25fc28527aa528336039fa27fa89ef3d7e32c