Bug 324044 - Improve MediaWiki export tool [patch]
Summary: Improve MediaWiki export tool [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-WebService-MediaWiki (show other bugs)
Version: 3.3.0
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-26 05:21 UTC by Peter Potrowl
Modified: 2018-02-04 13:02 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.0.0


Attachments
Patch described above (21.74 KB, patch)
2013-08-26 05:23 UTC, Peter Potrowl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Potrowl 2013-08-26 05:21:48 UTC
The proposed patch implements a feature requested by several users (1), fixes a bug (2) and improves the user interface (3).

1) Several users have asked for the possibility of removing the metadata and/or the GPS location from the file before uploading to MediaWiki. The metadata often contain the date and time the picture was taken, which can be considered private data in some cases. The GPS location is also a private data, when the picture was taken in a private location (home...).

This patch adds two checkbox, allowing the user to remove all the metadata from the file, or only the GPS location, before uploading it to the distant wiki. When the file is resized before uploading, the metadata is copied to the resized version only if the « Remove metadata from file » checkbox is unchecked. If the file is not resized and the checkbox is checked, a copy of the file is created and null metadata are saved in it.

2) In some cases, the description map of the files of the previous upload was not cleared when the user started a new upload. This caused the files of the previous upload to be re-uploaded without user notice.

This patch fixes this issue by clearing the images description map each time a new list of files is loaded.

3) This patch adds a few improvements to the user interface:
* the name of the wiki the user is currently logged on is now displayed
* the link to the current wiki does now show the name of this wiki instead of "MediaWiki"
* when adding a wiki, the user is now asked for the "API URL" of the wiki instead of the "URL" which was ambiguous
* the interface displays and upload more digits for the latitude and longitude than before

Please review and merge this patch. Best regards.

Reproducible: Always
Comment 1 Peter Potrowl 2013-08-26 05:23:28 UTC
Created attachment 81933 [details]
Patch described above
Comment 2 caulier.gilles 2013-08-26 06:55:25 UTC
Adrian,

Can you review the proposed patch please ? Thanks in advance...

Gilles Caulier
Comment 3 Peter Potrowl 2013-09-02 14:26:46 UTC
Dear Gilles and Adrian,

Any news concerning the review of this patch? I am sad it was not part of the 3.4.0 release...

Best regards
Comment 4 Peter Potrowl 2013-09-17 00:15:46 UTC
Dear Gilles and Adrian,

Any news concerning the review of this patch?

Best regards
Comment 5 Peter Potrowl 2013-10-01 19:53:00 UTC
Is there anything I can do to have this patch applied?

Will it help if I ask for a git developer access?

Best regards
Comment 6 caulier.gilles 2013-10-21 09:51:08 UTC
Peter,

Sorry for the delay, I have been perturbated in my opensource workflow due to a car crash. I'm back now.

I'm would to be happy to see sombody maintaining the plugin code. This include your patch of course. As i'm not a wikimedia user, i'm not the right person to test features. At least i can review coding style and other stuff relevant.

It's a good idea to take a developer account if you is motivated to be a maintainer for the future.

Let's me hear. Best

Gilles Caulier
Comment 7 Peter Potrowl 2013-10-21 15:39:29 UTC
Dear Gilles,

Thank you very much for your answer. I would be very happy to maintain the plugin code. This is my 4th patch on this plugin, after I carried out a 6-month project with two students from the University of Lille-I and an engineer from INRIA in order to make this plugin more useable.

I intend to continue developing this plugin and I intensely test the features before proposing patches. I would be very happy if you accepted to support me in my application for a developer account.

Best regards
Comment 8 caulier.gilles 2013-10-21 15:43:37 UTC
Well you is welcome.

Please follow instruction in this wiki page. I will be contacted by KDE admin for your registration as KDE developer.

http://community.kde.org/Sysadmin/GitKdeOrgManual#How_to_get_read-write_developer_access

Gilles Caulier
Comment 9 Peter Potrowl 2013-10-21 20:10:52 UTC
Dear Gilles,

I got my developer access. Can I commit the patch?

Best regards
Comment 10 caulier.gilles 2013-10-21 20:22:39 UTC
yes, you can.

When you commit, don't forget to close this file using BUGS macro to add in your commit comment. see here for details :

http://community.kde.org/Sysadmin/GitKdeOrgManual#Commit_hook_keywords

Use also FIXED-IN macro in your commit comment to register digiKam version where patch will be published (here "4.0.0"). For info, look release plan for details :

http://community.kde.org/Digikam/GSoC2013#Roadmap_and_Releases_Plan_including_all_GSoC-2013_works

Also, please register this bugzilla file title in kipi-plugins NEWS file. 

Finally, in NEWS file, register new feature add to mediawiki plugin. Look how it's do in previous release :

https://projects.kde.org/projects/extragear/graphics/kipi-plugins/repository/revisions/master/entry/project/NEWS.3.0.0

Gilles Caulier
Comment 11 Peter Potrowl 2013-10-21 21:49:40 UTC
Git commit a1c00a8405355ea8fc0b34cc7d4bd353c92d711a by Peter Potrowl.
Committed on 21/10/2013 at 21:36.
Pushed by peterpotrowl into branch 'master'.

MediaWiki: Fix bug, add feature, improve usability
FIXED-IN: 4.0.0

Files could be re-uploaded without notice because of a bug. Fixed.

The plugin now allows the user to remove the metadata and/or the GPS
coordinates before uploading.

Additionally, the interface has been slightly improved (see bug.)

M  +3    -1    NEWS
M  +85   -30   mediawiki/wmwidget.cpp
M  +9    -5    mediawiki/wmwidget.h
M  +56   -41   mediawiki/wmwindow.cpp
M  +3    -3    mediawiki/wmwindow.h

http://commits.kde.org/kipi-plugins/a1c00a8405355ea8fc0b34cc7d4bd353c92d711a