Bug 324001 - No next hand dealt
Summary: No next hand dealt
Status: RESOLVED FIXED
Alias: None
Product: kajongg
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Wolfgang Rohdewald
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-25 10:02 UTC by ospalh@gmail.com
Modified: 2014-02-10 04:11 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.12.3


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ospalh@gmail.com 2013-08-25 10:02:20 UTC
With the “Ready for the next hand” pop-up visible, push the space bar in the *main* window. Then click the OK button of the pop-up or push the space bar in the pop-up.

The pop-up disappears, but no next hand is dealt.

As a work-around, using “Abort game” and “Play/Resume game” works.
Comment 1 ospalh@gmail.com 2013-08-25 10:09:50 UTC
Actually, this only happens some of the time.
Not sure what other conditions apply.
Comment 2 Wolfgang Rohdewald 2013-09-10 23:36:17 UTC
can you please try this with master? (backup .kde/share/apps/kajongg and .kajonggserver because master will upgrade the database structure in a non-backwards compatible way)

also, is it different if you remove kajongg/src/qt4reactor.py (and .pyc) everywhere and install the package python-qt4reactor?

this debian package did not exist when I needed it, for copyright reasons. Now it differs from my older copy.

for a while I had this problem in master but somehow it disappeared. But now kajongg/master has a new option --debug=event which installs an app wide event filter. This filter showed me that the keypress event did reach the application but not the dialog. Mostly, but sometimes it did work.

examples:
kajongg --debug=events=all
kajongg --debug=events=KeyPress/Paint
Comment 3 Wolfgang Rohdewald 2014-02-09 20:01:44 UTC
Git commit 7737c2c665322f893930193ac3f9164adae2de3a by Wolfgang Rohdewald.
Committed on 09/02/2014 at 19:56.
Pushed by wrohdewald into branch 'KDE/4.11'.

Fix a bug where the next hand could not be started

this happened for me by doing:
- wait for prompt "ready for next hand?"
- use CTRL-T to show the scoring table. It must appear below the prompt.
- click in the scoring table
- click on the OK button of the prompt

this happens only if using PyKDE4 and a modal prompt. The KPushButton does get
the events MouseButtonPress and MouseButtonRelease, but the KDialog emits
neither buttonClicked nor clicked

Fix: When using PyKDE4, use a modal dialog here. This has the disadvantage
that it might be useful to open the scoring table at this point which is not
possible with this modal dialog (unless a specific button is added to the
dialog)
FIXED-IN: 4.11.7

M  +2    -2    src/humanclient.py
M  +0    -20   src/kde.py

http://commits.kde.org/kajongg/7737c2c665322f893930193ac3f9164adae2de3a
Comment 4 Jekyll Wu 2014-02-10 04:11:48 UTC
> Git commit 7737c2c665322f893930193ac3f9164adae2de3a by Wolfgang Rohdewald.
> Committed on 09/02/2014 at 19:56.
> Pushed by wrohdewald into branch 'KDE/4.11'.

Wolfgang, no need to push commit into KDE/4.11 branch any more. It is dead for future releases, except for the kde-workspace repo.