Bug 323761 - Identical hand replayed after “Abort game” and resume.
Summary: Identical hand replayed after “Abort game” and resume.
Status: RESOLVED FIXED
Alias: None
Product: kajongg
Classification: Applications
Component: general (show other bugs)
Version: 4.11.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Wolfgang Rohdewald
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-20 08:15 UTC by ospalh@gmail.com
Modified: 2013-08-29 12:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 4.11.1
Sentry Crash Report:


Attachments
Screen grab of the same score of the same hand, played three times. (31.58 KB, image/png)
2013-08-20 08:16 UTC, ospalh@gmail.com
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ospalh@gmail.com 2013-08-20 08:15:17 UTC
Under certain circumstances the exact same hand, with the same label (e.g. E1 *without* an added letter) and the same tiles is replayed.


Reproducible: Sometimes

Steps to Reproduce:
1.  Play a hand of kajongg
2. Not quite sure, but maybe the hand has to end so that the there would be a repeat hand – which should of course use different tiles – like an East wind win, or a draw.
3. Close kajongg
4. Re-start kajong, press play, select the old game.
Actual Results:  
The exact same hand is played again.
For example after the hand E1/895380045, the hand  E1/895380045, with the same tiles, appears again.

Expected Results:  
The next hand,  (E1*a*/895380045), should have been started.

I ran kajongg from the kde git repo, with the newest 4.11.1 changes.
The house rules is just removing the bonus tiles and reducing the limit to 300.
Comment 1 ospalh@gmail.com 2013-08-20 08:16:16 UTC
Created attachment 81798 [details]
Screen grab of the same score of the same hand, played three times.
Comment 2 Wolfgang Rohdewald 2013-08-24 02:56:50 UTC
Git commit ce148cc889d1efa12f3064af5070ab8d3fb3ead1 by Wolfgang Rohdewald.
Committed on 24/08/2013 at 02:51.
Pushed by wrohdewald into branch 'KDE/4.11'.

fix resuming a game when the previous hand did not make winds rotate
FIXED-IN: 4.11.1

M  +1    -0    src/game.py

http://commits.kde.org/kajongg/ce148cc889d1efa12f3064af5070ab8d3fb3ead1
Comment 3 Wolfgang Rohdewald 2013-08-29 12:23:35 UTC
Git commit 1948aaf3e50caca2710b13198e366496bd7f7b29 by Wolfgang Rohdewald.
Committed on 24/08/2013 at 02:51.
Pushed by wrohdewald into branch 'master'.

fix resuming a game when the previous hand did not make winds rotate
FIXED-IN: 4.11.1

M  +1    -0    src/game.py

http://commits.kde.org/kajongg/1948aaf3e50caca2710b13198e366496bd7f7b29