Bug 323632 - Analyzer visible when there's no support for visualization
Summary: Analyzer visible when there's no support for visualization
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Context View/Spectrum Analyzer (show other bugs)
Version: 2.8.0
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: 2.9
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-17 11:33 UTC by Konrad Zemek
Modified: 2014-05-21 10:24 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Konrad Zemek 2013-08-17 11:33:53 UTC
When there's no necessary support for visualization in the backend, Analyzer widget should be hidden.

Reproducible: Always

Steps to Reproduce:
1. Run Amarok 2.8 on Windows
2.
3.
Actual Results:  
The Analyzer widget is visible by default.

Expected Results:  
The Analyzer widget is hidden by default.
Comment 1 Mark Kretschmann 2013-08-17 14:02:23 UTC
The super odd thing is that I cannot reproduce this issue on Linux. With Phonon-VLC the analyzer  is not added automatically here.
Comment 2 vedant agarwala 2013-08-18 08:28:13 UTC
Recently, when I did a complete reinstall of my Kubuntu (and hence Amarok) an "unknown widget" was being displayed whose "content could not be loaded" (or some similar string was being displayed).
Comment 3 Mark Kretschmann 2013-08-18 09:08:29 UTC
@Vedant: That's unrelated, it was a bug in git master that I fixed one day later.
Comment 4 Mark Kretschmann 2013-08-18 10:25:57 UTC
Git commit e631534993c03244a36ed013c186ad8bf83ca1fd by Mark Kretschmann.
Committed on 18/08/2013 at 10:22.
Pushed by markey into branch 'master'.

Don't add the analyzer applet when Phonon doesn't support it.

Stupid... I forgot about that file.
BACKPORT

M  +1    -1    data/amarok_homerc

http://commits.kde.org/amarok/e631534993c03244a36ed013c186ad8bf83ca1fd
Comment 5 vedant agarwala 2014-05-21 10:24:47 UTC
Git commit d15907828851a7d95461edbc7e32716aae291814 by Vedant Agarwala, on behalf of Mark Kretschmann.
Committed on 18/08/2013 at 10:22.
Pushed by vedanta into branch 'tagguessing'.

Don't add the analyzer applet when Phonon doesn't support it.

Stupid... I forgot about that file.
BACKPORT

M  +1    -1    data/amarok_homerc

http://commits.kde.org/amarok/d15907828851a7d95461edbc7e32716aae291814