Bug 322770 - Unable to pass additional arguments to pep8 checker
Summary: Unable to pass additional arguments to pep8 checker
Status: RESOLVED FIXED
Alias: None
Product: kdev-python
Classification: Developer tools
Component: general (show other bugs)
Version: 1.5.x
Platform: Other Linux
: NOR normal
Target Milestone: 1.6.0
Assignee: Sven Brauch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-24 13:05 UTC by Hai Zaar
Modified: 2013-11-21 11:49 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hai Zaar 2013-07-24 13:05:09 UTC
I'm trying to set pep8 checker as:
/usr/bin/pep8 --max-line-length=120

Unfortunately this --max-line-length=120 argument seems to break the way kdev-python invokes it:
"The selected PEP8 syntax checker "/usr/bin/pep8 --max-line-length=120" does not seem to work correctly." 

Reproducible: Always

Steps to Reproduce:
See description



kdev-python 1.5.1; kdevelop 4.5.1; Kubuntu 13.04 64-bit
Comment 1 Sven Brauch 2013-07-24 13:09:13 UTC
I figured the way to do this would be just this:
1) create a mypep8.sh script containing the options you want
2) point kdevelop to that...

Not sure if it's worth implementing passing arguments from the GUI...
Comment 2 Hai Zaar 2013-07-24 13:15:59 UTC
How about just invoking whatever is given in GUI through the shell?
After all this what you are effectively achieving in the workaround you
suggested.


On Wed, Jul 24, 2013 at 4:09 PM, Sven Brauch <svenbrauch@googlemail.com>wrote:

> https://bugs.kde.org/show_bug.cgi?id=322770
>
> --- Comment #1 from Sven Brauch <svenbrauch@googlemail.com> ---
> I figured the way to do this would be just this:
> 1) create a mypep8.sh script containing the options you want
> 2) point kdevelop to that...
>
> Not sure if it's worth implementing passing arguments from the GUI...
>
> --
> You are receiving this mail because:
> You reported the bug.
>
Comment 3 Sven Brauch 2013-07-24 13:24:06 UTC
Well, running a shell command is much more complicated than starting a process in the core of it. Starting a process is just telling the operating system "start this process", while starting a shell command requires something to do parsing of the command line arguments, requires knowledge about the shell environment, ...
It's easy to do, but it's much less clean than just spawning a process. But yeah, I can add a line edit to pass some arguments, sure.
Comment 4 Sven Brauch 2013-11-21 11:49:50 UTC
Git commit 7c36eaf68938acc4fc72fcaac0224f0c3b5038e0 by Sven Brauch, on behalf of Benjamin Kaiser.
Committed on 21/11/2013 at 10:56.
Pushed by brauch into branch 'master'.

Support passing arguments to the PEP8 checker.

REVIEW:113989
CCMAIL:benjaminjkaiser@gmail.com

M  +5    -0    pep8kcm/kcm_pep8.cpp
M  +1    -0    pep8kcm/kcm_pep8.h
M  +6    -1    pythonparsejob.cpp

http://commits.kde.org/kdev-python/7c36eaf68938acc4fc72fcaac0224f0c3b5038e0