Bug 322188 - PHP 5.3 heredoc and nowdoc syntax
Summary: PHP 5.3 heredoc and nowdoc syntax
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: syntax (show other bugs)
Version: 3.10.90
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL: http://php.net/manual/en/language.typ...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-10 11:14 UTC by Nikola Kovacs
Modified: 2013-07-15 16:19 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/kate/1e5b1971963b6239a69631e6ded21cf0ece91cae
Version Fixed In: 4.12
Sentry Crash Report:

Attachments
Test cases (1.71 KB, text/plain)
2013-07-10 11:15 UTC, Nikola Kovacs 		Details
Patch (4.83 KB, patch)
2013-07-10 11:17 UTC, Nikola Kovacs 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nikola Kovacs 2013-07-10 11:14:02 UTC 
Since PHP 5.3,  the opening heredoc identifier may optionally be enclosed in double quotes, and nowdoc is also supported (opening identifier enclosed in single quotes, variables are not expanded)

Reproducible: Always
Comment 1 Nikola Kovacs 2013-07-10 11:15:38 UTC 
Created attachment 81043 [details]
Test cases

test file with all the special identifiers kate recognizes (EOHTML, EOCSS, EOJAVASCRIPT, EOMYSQL) in all three syntaxes (heredoc, heredoc with double quotes, nowdoc)
Comment 2 Nikola Kovacs 2013-07-10 11:17:37 UTC 
Created attachment 81044 [details]
Patch
Comment 3 Dominik Haumann 2013-07-15 15:47:32 UTC 
Git commit 1e5b1971963b6239a69631e6ded21cf0ece91cae by Dominik Haumann.
Committed on 15/07/2013 at 15:47.
Pushed by dhaumann into branch 'master'.

fix PHP 5.3 heredoc and nowdoc syntax

Please other users/developers test this.
I don't really know whether this patch is correct.

FIXED-IN: 4.12

M  +214  -0    examples/syntax/highlight.php
M  +37   -1    part/syntax/data/php.xml

http://commits.kde.org/kate/1e5b1971963b6239a69631e6ded21cf0ece91cae
Comment 4 Miquel Sabaté 2013-07-15 16:19:25 UTC 
(In reply to comment #3)
> Git commit 1e5b1971963b6239a69631e6ded21cf0ece91cae by Dominik Haumann.
> Committed on 15/07/2013 at 15:47.
> Pushed by dhaumann into branch 'master'.
> 
> fix PHP 5.3 heredoc and nowdoc syntax
> 
> Please other users/developers test this.
> I don't really know whether this patch is correct.
> 
> FIXED-IN: 4.12
> 
> M  +214  -0    examples/syntax/highlight.php
> M  +37   -1    part/syntax/data/php.xml
> 
> http://commits.kde.org/kate/1e5b1971963b6239a69631e6ded21cf0ece91cae

Works for me :)