Bug 321728 - Javascript highlight is broken since commit 13eee5d37687dbbe2ed1195168e423695551207c
Summary: Javascript highlight is broken since commit 13eee5d37687dbbe2ed1195168e423695...
Status: RESOLVED DUPLICATE of bug 321859
Alias: None
Product: kate
Classification: Applications
Component: syntax (show other bugs)
Version: 3.10.80
Platform: Arch Linux Linux
: VHI grave
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-28 18:53 UTC by Nikita Skovoroda
Modified: 2013-07-20 11:24 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Testcase (99 bytes, text/javascript)
2013-06-28 18:54 UTC, Nikita Skovoroda 		Details
Screenshot of the bug (on the testcase) (8.15 KB, image/png)
2013-06-28 18:57 UTC, Nikita Skovoroda 		Details
Screenshot of the bug (on the Leaflet source code). (61.20 KB, image/png)
2013-06-28 19:39 UTC, Nikita Skovoroda 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Skovoroda 2013-06-28 18:53:05 UTC 
See the attached file or http://paste.kde.org/775436/

Reproducible: Always

Steps to Reproduce:
1. Save the attached file as file.js
2. Open it.
3. Check the syntax highlight.
Actual Results:  
The syntax highlight is broken.

Expected Results:  
The syntax highlight should not be broken.

See the attached images for real-world examples.

Workaround: revert 13eee5d37687dbbe2ed1195168e423695551207c.

I am aware that 13eee5d37687dbbe2ed1195168e423695551207c fixes other issues, but it introduces heavier problems than it solved. I don't know how to fix that in a good manner, but probably there should be a better solution than just reverting the commit.
Comment 1 Nikita Skovoroda 2013-06-28 18:54:51 UTC 
Created attachment 80837 [details]
Testcase
Comment 2 Nikita Skovoroda 2013-06-28 18:57:30 UTC 
Created attachment 80838 [details]
Screenshot of the bug (on the testcase)
Comment 3 Nikita Skovoroda 2013-06-28 19:39:20 UTC 
Created attachment 80840 [details]
Screenshot of the bug (on the Leaflet source code).
Comment 4 Nikita Skovoroda 2013-06-28 20:37:54 UTC 
This bug is valid for kate 3.10.80 (KDE SC 4.10.80) and kate 3.10.90 (KDE SC 4.10.90).
Comment 5 Joseph Wenninger 2013-07-16 10:07:35 UTC 
I can confirm this bug. What was the problem with spaces being identified as part of member names? Did that cause problems somewhere else?
Comment 6 Dominik Haumann 2013-07-16 21:25:56 UTC 
Then it should be reverted. A fix then can still be provided.
Comment 7 Joseph Wenninger 2013-07-18 23:31:10 UTC 
Does anybody have a quick solution or shall I revert?
Comment 8 Philipp A. 2013-07-19 15:52:14 UTC 
somebody broke it anyway, so go ahead and revert.

but we have that space problem. i filed a bug for it: https://bugs.kde.org/show_bug.cgi?id=322577
Comment 9 Milian Wolff 2013-07-20 11:05:45 UTC 
fixed this already

*** This bug has been marked as a duplicate of bug 321859 ***
Comment 10 Philipp A. 2013-07-20 11:24:29 UTC 
why would you think that i’d mention that i created a duplicate bug while being aware that this bug exists?

i filed bug 322577 because the reverting is just wrong in another way. please look at the test case in bug 322577 to see what should work simultaneously.