Bug 321226 - Clicking the "security badge" on an HTTPS site opens multiple dialogs
Summary: Clicking the "security badge" on an HTTPS site opens multiple dialogs
Status: RESOLVED FIXED
Alias: None
Product: rekonq
Classification: Applications
Component: general (show other bugs)
Version: 2.3.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: 3.0
Assignee: Andrea Diamantini
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-16 15:09 UTC by Rudy Raab
Modified: 2013-07-13 17:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of described behavior (80.83 KB, image/png)
2013-06-16 15:44 UTC, Rudy Raab
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rudy Raab 2013-06-16 15:09:24 UTC
Clicking the badge once opens several copies of the dialog overlaid on one another (so it looks like only one). The drop-shadow effect around it also grows in proportion to how many dialogs are open. 

The reason I rated it as major is because sometimes (usually if you refresh the page in question), clicking the badge opens so many dialogs that it overwhelms the OS and KDE freezes entirely, necessitating a restart with the hardware power button. 

That's also why I can't get a good screenshot; any time when there's enough dialogs to prove my point, it also freezes the system. 

Using the 2.3.0 release compiled from sources on OpenSUSE 12.3 x64 with KDE 4.10.4.
Comment 1 Rudy Raab 2013-06-16 15:44:17 UTC
Created attachment 80556 [details]
Screenshot of described behavior

Screenshot of the multiple open dialogs. In this case no refresh of the page was needed to make clicking the badge open this many.
Comment 2 Rudy Raab 2013-06-16 15:48:29 UTC
I have reduce the severity of this bug as I've learned that the dialogs do not freeze the system. They only keep steal focus and don't allow me to interact with anything else, and also block keypresses. Every click on anything else closes one dialog, so spamming my mouse button enough will close all the dialogs. However there will be significant RAM usage left over until rekonq is closed.
Comment 3 Andrea Diamantini 2013-06-20 16:59:00 UTC
sorry, the security badge is the "green shield icon" on the left side of
the urlbar opening a popup? Your problem is that you click there and A LOT
of popups appear, right?


2013/6/16 Rudy Raab <rrrperson@gmail.com>

> https://bugs.kde.org/show_bug.cgi?id=321226
>
>             Bug ID: 321226
>            Summary: Clicking the "security badge" on an HTTPS site opens
>                     multiple dialogs
>     Classification: Unclassified
>            Product: rekonq
>            Version: 2.3.0
>           Platform: Compiled Sources
>                 OS: Linux
>             Status: UNCONFIRMED
>           Severity: major
>           Priority: NOR
>          Component: general
>           Assignee: adjam7@gmail.com
>           Reporter: rrrperson@gmail.com
>
> Clicking the badge once opens several copies of the dialog overlaid on one
> another (so it looks like only one). The drop-shadow effect around it also
> grows in proportion to how many dialogs are open.
>
> The reason I rated it as major is because sometimes (usually if you
> refresh the
> page in question), clicking the badge opens so many dialogs that it
> overwhelms
> the OS and KDE freezes entirely, necessitating a restart with the hardware
> power button.
>
> That's also why I can't get a good screenshot; any time when there's enough
> dialogs to prove my point, it also freezes the system.
>
> Using the 2.3.0 release compiled from sources on OpenSUSE 12.3 x64 with KDE
> 4.10.4.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
>
Comment 4 Rudy Raab 2013-06-20 19:19:15 UTC
Yes, I click the green shield icon and quite a lot of popups appear. All of them copies of the one another, overlayed on each other. As they open, I can see the shadow effect around them grow outward. 

(In reply to comment #3)
> sorry, the security badge is the "green shield icon" on the left side of
> the urlbar opening a popup? Your problem is that you click there and A LOT
> of popups appear, right?
>
Comment 5 Antonis G. 2013-07-07 21:44:12 UTC
I have same problem here. It is quite strange. Try visiting https://www.archlinux.org/ there is no problem at all, now reloading the page gives me 2 popups (I have to click with my mouse twice to make the disapear, reloading again gives me more popups...
Comment 6 Rudy Raab 2013-07-08 19:42:56 UTC
I just tried that link. On the first visit, it was normal (one popup). After reloading once, I got 9 popups overlaid. After reloading a second time, I got a full 28 popups (I counted the clicks). I don't want to try a third reload. 

(In reply to comment #5)
> I have same problem here. It is quite strange. Try visiting
> https://www.archlinux.org/ there is no problem at all, now reloading the
> page gives me 2 popups (I have to click with my mouse twice to make the
> disapear, reloading again gives me more popups...
Comment 7 Andrea Diamantini 2013-07-12 13:49:21 UTC
Git commit 27addebee71183965720662b05be2caf619d4d57 by Andrea Diamantini.
Committed on 12/07/2013 at 13:46.
Pushed by adjam into branch 'master'.

Review ssl widget generation code.

This also seems to fix some way problem about multiple widget creations

What about you, guys?

M  +22   -3    src/urlbar/urlbar.cpp
M  +2    -1    src/urlbar/urlbar.h
M  +2    -14   src/webtab/webpage.cpp
M  +4    -3    src/webtab/webpage.h

http://commits.kde.org/rekonq/27addebee71183965720662b05be2caf619d4d57
Comment 8 Rudy Raab 2013-07-12 15:41:26 UTC
I just built rekonq from git master and the issue appears fixed. Tested on multiple sites. Nice work, Andrea. We'll see if Antonis confirms.
Comment 9 Antonis G. 2013-07-12 18:05:38 UTC
Wep it does, many thanks!!
Comment 10 Andrea Diamantini 2013-07-13 17:04:29 UTC
Ok, guys! Thank you for the bug report and the tests. Closing as fixed. Just ping here again if it is not the case :)