Bug 321027 - "Automatically Select Coordinate Grid" should disable toolbar buttons
Summary: "Automatically Select Coordinate Grid" should disable toolbar buttons
Status: RESOLVED FIXED
Alias: None
Product: kstars
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Akarsh Simha
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-11 14:01 UTC by Rishab Arora
Modified: 2017-02-27 15:58 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Proposed patch. (1.69 KB, patch)
2013-06-12 09:41 UTC, Aneesh Dogra
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rishab Arora 2013-06-11 14:01:00 UTC
If "Automatically Select Coordinate Grid" is on, then the buttons to enable/disable equatorial and horizontal grids should be disabled.

Currently, enabling/disabling them gives no feedback and it appears to be broken unless you check the configuration.

Reproducible: Always

Steps to Reproduce:
1. Go to Settings -> Configure KStars -> Guides
2. Enable "Automatically Select Coordinate Grid". Click OK.
3. Try using Coordinate Grid buttons on the Toolbar
Actual Results:  
Nothing happens. But buttons work.

Expected Results:  
Buttons should be disabled.
Comment 1 Aneesh Dogra 2013-06-12 09:41:09 UTC
Created attachment 80468 [details]
Proposed patch.

I don't think disabling the buttons would be the expected behavior. I think if the user is asking to display the equatorial/horizontal grid we should just disable "Automatically select coordinate grid" and do what he wants.
Comment 2 Jasem Mutlaq 2015-01-28 07:10:08 UTC
Git commit c39e30a782bb7b17a6b08e8fe7840efaaeee124f by Jasem Mutlaq.
Committed on 28/01/2015 at 07:08.
Pushed by mutlaqja into branch 'master'.

Applying patch by Aneesh Dogra, thanks a lot!! This fixes setting the horizontal and equatorial grids.

M  +7    -0    kstars/kstarsactions.cpp

http://commits.kde.org/kstars/c39e30a782bb7b17a6b08e8fe7840efaaeee124f