It's nice to have percentage volume indicator(s) on KMix window. I have sliders with graduation, but I don't know how value (in percent) have sound level. Some times ago KMix had percentage volume indicator, and after it disappeared, why. I think it is very useful. Could you consider to add it again. Reproducible: Always
I do not have neither time nor interest to do so. If somebody else feels like implementing it, please let me know, and I'll help you to get a start.
Patch to implement this: https://git.reviewboard.kde.org/r/114640/
@Christian Esken I feel like doing it and would be glad if you could show me the right direction. I am new here.
I have verified this bug in kmix 4.4 and I agree with Piotr Mierzwinski , it would be nice to have a percentage volume indicator. By the way I am completely new in this. So, can any one guide me that how can I get the permission to confirm an unconfirmed bug?
Created attachment 91872 [details] zipped file holding the diff files for my proposed patch. This is a patch I have created in an attempt to add a volume percentage display, which should default to being off.
Do you know, is there any chance to have percentage indicator with next release of platform? Probably this question shoud be director to maintaner: Christian Esken, because he accepts all patches. :/
Created attachment 92120 [details] zipped file holding the diff files for my proposed patch.
Currently KMix is feature complete from my side. I am working on a policy for new features. For now please proceed like this: - Submit patch to https://git.reviewboard.kde.org/ . Please also specifiy whether you have write access to the repository. - Organize Review: 1) Notfiy esken@kde.org and the kde multimedia list on the Review 2) Wait for review. I am only doing minor maintenance work on KMix every couple of months, so if you do not hear within 2-4 weeks, please re-notify. - Be prepared to maintain your changes over an extended period of time. About your specific patch: Make sure the percentage indication is off by default, and confuiguration is in the correct Configuration Tab.
By the way. I just found a pecentage tooltip on the Reviewboard: https://git.reviewboard.kde.org/r/123121/ It is less intrusive than a permanently shown percentage, so I would rather opt to use https://git.reviewboard.kde.org/r/123121/
Could you tell me what is wrong in showing percentage indicator (on user wish, because default would be invisible)? I would like to know what is value of sound volume. Why it has been discarded? Is it distracted the user? Graduation without showing value is not much usable, because then I need to count the lines to find out what is value :/. I would like to set it precisely and be able to find out what is value in the easiest way as possible. In above solution I have to move slider to find out what is value, if I correct understood description. Anyway user will be forced to do additional not necessary actions to find out something about sound volume. He will have to check every slider to get this information. On opposite side we can have easiest way, because when percentage indicators are visible then it's enough only one glance and we know all. I think this is more comfortable and more usable for user. And if some user don't want to see it then will be able to hide or don't show (it default would be invisible). I hope that KDE is never becoming like Gnome, where a lot of options are hidden, because they probably know what user want and what doesn't. I would like to have a choice. a variety of options this is the power of KDE, please don't abandon it.
Created attachment 92219 [details] attachment-20622-0.html I'll submit my patch to the Reviewboard, but I tested my patch and, at least on my system, the indicator defaults to being off and has a configuration option. This patch shouldn't be permanent. The invasiveness was so that configuration is possible. I tried to edit as little within each file as I could, though. ----- Original Message ----- From: "Christian Esken" <esken@kde.org> To: "gabe giles" <gabe.giles@comcast.net> Sent: Saturday, April 25, 2015 4:49:17 AM Subject: [kmix] [Bug 320949] Percentage indicator on KMix window https://bugs.kde.org/show_bug.cgi?id=320949 --- Comment #9 from Christian Esken <esken@kde.org> --- By the way. I just found a pecentage tooltip on the Reviewboard: https://git.reviewboard.kde.org/r/123121/ It is less intrusive than a permanently shown percentage, so I would rather opt to use https://git.reviewboard.kde.org/r/123121/
Created attachment 92220 [details] attachment-24384-0.html I just submitted my patch to the Reviewboard. While it's more intrusive, I consider the ability to turn it on and off to be an improvement. I tested it and the percentage is only permanently shown if the user wants to see it. The only headache is that the default is currently on. I have not found where to change that. ----- Original Message ----- From: "Christian Esken" <esken@kde.org> To: "gabe giles" <gabe.giles@comcast.net> Sent: Saturday, April 25, 2015 4:49:17 AM Subject: [kmix] [Bug 320949] Percentage indicator on KMix window https://bugs.kde.org/show_bug.cgi?id=320949 --- Comment #9 from Christian Esken <esken@kde.org> --- By the way. I just found a pecentage tooltip on the Reviewboard: https://git.reviewboard.kde.org/r/123121/ It is less intrusive than a permanently shown percentage, so I would rather opt to use https://git.reviewboard.kde.org/r/123121/
Piotr, my personal reasons are: - Overlap: -- While not fully overlapping, it is a bit redundant with the other patch from reviewboard -- Organize changes with that other patch - More Clutter in Config dialog - You have to get it right and test whether layout will be correct: -- horizontal and vertical. -- Test layout In main window and tray -- Test all that again with theme changes -- Please note that the - Long-term development commitment. Layouts tend to break with Qt, Window manger, Plasma or other library changes. Why it has been discarded? It was never available in KDE4, and the original person who submitted the change had obviously no interest in porting it form KDE3 to KDE4. This is why I must ask you (and you should ask yourself): Will you port it to KDE4 and KDE5? What about fixes for Wayland?
Adding the incomplete sentence: -- Please note that the popup does likely will not have any of these layout issues. I just want to let you know from the history, that changes in MDWSlider often brought hours and days of layout issues debugging, including reading much Qt and KDE sourcecode.
Thanks for posting it to Reviewboard. Please post the reviewboard URL or the review ID here, so I can find it.
My proposed patch is at https://git.reviewboard.kde.org/r/123503/
@Christian [Christian] - Overlap: I think this is issue of merge the patches or choosing the best option. From my side the best option is that more usable/comfortable for end user. [Christian] - More Clutter in Config dialog Please. One more option didn't make that config dialog will be more cluttered than it is. Just check Configure in KMix (KDE4). We can see there in section General->Visual three options one below the other. In my opinion one more will not make difference. Configure in KMix: https://kmix5.files.wordpress.com/2013/12/2013-12-kmixsoundmenu.png And by the way. I think this screen doesn't look too good. I'm not GUI designer, but I can send some proposal to Reviewboard. I'm talking, of course, about KDE4, but for Frameworks 5 I found screen where Configure dialog looks very similar. I'm not sure if now something changed. https://kmix5.wordpress.com/2014/08/14/kmix-on-kde-frameworks-5/ [Christian] - You have to get it right and test whether layout will be correct: -- horizontal and vertical. -- Test layout In main window and tray -- Test all that again with theme changes -- Please note that the - Long-term development commitment. Layouts tend to break with Qt, Window manger, Plasma or other library changes. I think this is directed to Gabe (or other person who put proposal in Reviewboard). :/ I think that layout (in Qt) is breaking in rare situation. This should be huge changes. I'm talking base on my experience with using KDE and their application in other WMs. Layout can go break also by incorrect design made by programmer where labels have fixed sizes, so reviewer should check it. I understand that tool tip from https://git.reviewboard.kde.org/r/123121/ is not able to break dialog, so you will not have to worry these issues. But I think that from user side more comfortable is my proposal. End user and maintainer/person like you have different objectives. One of them want pretty and comfortable GUI and second want less work in maintaining. Unfortunately are often conflicting objectives. :-/ [Christian] Why it has been discarded? It was never available in KDE4, and the original person who submitted the change had obviously no interest in porting it form KDE3 to KDE4. The most likely you are right about no existing percentage indicator in KMix with KDE4. I don't remember when I've seen it. I was sure it was (in some older version), thats why I've told about discarding. To be sure I did some research and I found a lot of screen shots where there wasn't percentage, but there were two (as below) where seems that such indicator existed, or maybe this is only design concept :-/. I'm not able to prove it. http://jhau.maliwi.de/linux/img/kmix-in.png http://2.bp.blogspot.com/-5aTQjCb58L0/TmlE_cmtbaI/AAAAAAAABJY/S3GN1wvPgNg/s1600/audio_conf.png Additionally some screens which (for sure) are looking like some proposals, because they come from "reviewboard". https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/9d6b0ca4-5a75-45cc-ab8e-61b13d4079e6__kmix_horizontal_new.png https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png [Christian] This is why I must ask you (and you should ask yourself): Will you port it to KDE4 and KDE5? What about fixes for Wayland? Again I think this is directed to Gabe, but I'll try to take a stand. I think we are talking here about KDE4 :-/. And about KDE5 (actually Frameworks 5) that I think there GUI is done in QML2 (Qt Quick 2) so any changes/fixes are easiest to made and how it will looks like depends to Qt5 (and QML2 interpreter). I don't know if KMix GUI is already ported to Qt Quick2, probably not. I'm not sure if Gabe is familiar with this technology (this is question to him). And who will port tool tip from .../r/123121/. Is there any volunteer? About Wayland. I'm not expert from Wayland (for sure Martin Gräßlin it is). Reading Martin's posts in planetkde I'm not sure if any changes in Wayland depend to Qt/KDE GUI. By the way I'm not happy that from Plasma 5 and Frameworks 5 disappearing percentage indicators (I saw some screenshots, for instance referring to energy management). @Gabe If this is no problem then could you upload to Reviewboard some screenshot(s) of your proposal and make it as public, because I met message: "You don't have access to this review request." when I was trying check it. Thanks in advance. @Christian Of course you will do what you want. I'm not insist you to chose my proposal and Gabe patch. I've told you why I think that it is better than current design. I'm KDE users from years and just I want that KDE was the best (usable and comfortable). :-)
I'm willing to make the proposal public, but when I try, it says I need a reviewer before I can publish the review request. I tried reviewing the request myself, but it still won't let me publish. How do I make a request public?
I think the review request is now public, though with some extraneous reviews.
As far as I can tell the current mixer in KDE offers percentage level visualization. Shouldn't this entry be closed?
Percentage indication is available during dragging volume pointer as tooltip.