Bug 320908 - The position rule should have a gravity feature
Summary: The position rule should have a gravity feature
Status: RESOLVED DUPLICATE of bug 132347
Alias: None
Product: kwin
Classification: Plasma
Component: rules (show other bugs)
Version: 4.10.4
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL: https://git.reviewboard.kde.org/r/110...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-08 15:38 UTC by Teodor
Modified: 2022-03-31 07:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
thomas.luebking: ReviewRequest+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Teodor 2013-06-08 15:38:50 UTC
If you create a rull with forced position, the position of a window is not actualy locked, because you can change it by resising: just move the upper left corner of the window.

Imagine that you want a window in the lower right corner of the screen to be locked in that position relatively to it's lower right corner but with opportunity to move only the upper left corner of the window. With current kwin behavior you will not be able to do that.

Solution: add an option to  lock custom corner(s) from being resised

Reproducible: Always
Comment 1 Thomas Lübking 2013-06-08 17:10:38 UTC
The solution will be to prevent gravity impacting resizing.
Comment 2 Teodor 2013-06-09 09:02:17 UTC
>to: Thomas Lübking

What is "gravity impacting resizing"?
Comment 3 Thomas Lübking 2013-06-09 09:24:47 UTC
for a left-to-right culture, resizing impacting the top-left corner (but actually the rule isn't gravity or even ltr aware, so the solution is basically that - you won't be presented the option to move on the top or left edge (including the bottomleft corner)
Comment 4 Teodor 2013-06-09 09:36:48 UTC
you won't be presented the option to move on the top or left edge (including the bottomleft corner)
BUT it is not what I was was talking about!
As always you make a simple solution, that solves only a half of a problem, but you don't care about things that become worse! Ability to resize from left corner is needed, but, as I sad, need an opportunity to lock custom corners from moving
Comment 5 Thomas Lübking 2013-06-09 09:49:57 UTC
> As always
Ok, sorry that i'm such a dickhead that always does bad.
I suggest you implement the feature and present a patch for 4.12.



The patch solves what you mentioned in the first place and *WHAT IS A BUG*:
> If you create a rull with forced position, the position of a window is not actualy locked, because you can change it by resising: just move the upper left corner of the window.

The additional:
> Imagine that you want a window in the lower right corner of the screen to be locked in that position relatively to it's lower right corner but with opportunity to move only the upper left corner of the window.

Is the completely *unrelated* call to make the position rule gravity aware - had you simply asked that instead of jabbering some wrong nonsense like

> No ability to resize windows without losing locked window position

and then pointing a behavioural bug i would probably not have seen the bug (so thank you for that) and instead asked: "reason?"

But now i'm out, sorry for wasting your time.
Comment 6 Teodor 2013-06-09 10:38:11 UTC
>Ok, sorry that i'm such a dickhead that always does bad.
When I was saying "you", I didn't meen "exactly YOY", I did meen "KDE developers". It is a pitty, that "exactly you" and "all of you" is the same in English, instead of Russian.

>The patch solves what you mentioned in the first place and *WHAT IS A BUG*:
Actualy this bugreport is more "wishlist" then "a bug", because you always can lock resizing too.
Anyway, it would be good if you implement it with a deactivatable option with checkbox, if you're really going to dao that.

>The additional:
Actualy, that was a major reason for creating this 'wish'.

Sorry for my bad English
Comment 7 Thomas Lübking 2013-06-10 14:57:11 UTC
Git commit 25134de4a121662686d7aa96fe79bce94c4d9b9f by Thomas Lübking.
Committed on 08/06/2013 at 20:16.
Pushed by luebking into branch 'master'.

prevent NW resizing when window has fixed position
REVIEW: 110895

M  +3    -0    kwin/geometry.cpp

http://commits.kde.org/kde-workspace/25134de4a121662686d7aa96fe79bce94c4d9b9f
Comment 8 heenamahour 2013-06-28 07:29:01 UTC
Git commit dd65e879af22e696ff96e96605e461cac28231c8 by heena mahour, on behalf of Thomas Lübking.
Committed on 08/06/2013 at 18:16.
Pushed by heenamahour into branch 'heenamahour/window-list'.

prevent NW resizing when window has fixed position
REVIEW: 110895

M  +3    -0    kwin/geometry.cpp

http://commits.kde.org/kde-workspace/dd65e879af22e696ff96e96605e461cac28231c8
Comment 9 Thomas Lübking 2013-10-12 19:51:20 UTC
Since resizing away from a locked position is fixed, this is now a dupe

*** This bug has been marked as a duplicate of bug 132347 ***