Bug 320168 - Untranslatable strings in Kexi Reports and Open Project dialogs
Summary: Untranslatable strings in Kexi Reports and Open Project dialogs
Status: CLOSED FIXED
Alias: None
Product: KEXI
Classification: Applications
Component: General (show other bugs)
Version: 2.6.3
Platform: Ubuntu All
: NOR minor
Target Milestone: 2.8
Assignee: Jarosław Staniek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-23 11:54 UTC by André Marcelo Alvarenga
Modified: 2014-01-12 20:42 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/calligra/06e48a4df0750286b15db4a0b2414769555851b9
Version Fixed In: 2.8.0 RC1
staniek: Translation_missing+

Attachments
Screenshot (54.85 KB, image/png)
2013-05-23 11:55 UTC, André Marcelo Alvarenga 		Details
untranslated file types in Project Open dialog (11.07 KB, image/png)
2013-12-08 13:07 UTC, Burkhard Lück 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description André Marcelo Alvarenga 2013-05-23 11:54:40 UTC 
Warning dialog:

String: "Design of object "%1" has been modified." 

I got this warning message when I try close the 'relatorio1' tab (Report).

(see screenshot [1])



Open Project dialog:

String: "all files"

(see screenshot [2])

Reproducible: Always
Comment 1 André Marcelo Alvarenga 2013-05-23 11:55:35 UTC 
Created attachment 80036 [details]
Screenshot
Comment 2 Jarosław Staniek 2013-05-25 09:55:45 UTC 
Thanks for the quality report. Can you see similar missing translation when you try to close unsaved forms or tables as well?
Comment 3 André Marcelo Alvarenga 2013-05-25 22:23:33 UTC 
(In reply to comment #2)
> Thanks for the quality report. Can you see similar missing translation when
> you try to close unsaved forms or tables as well?

This problem occurs only with Report's tabs. When I close other tabs, the messages are translated.
Comment 4 Jarosław Staniek 2013-12-08 00:34:05 UTC 
Confirmed the report's bug.

Regarding translation for "all files", it should come from KDE libraries, not Kexi. Perhaps you do not have installed all needed translations? 

Related thread: http://forum.kde.org/viewtopic.php?f=221&t=118542
Comment 5 Jarosław Staniek 2013-12-08 00:34:47 UTC 
Git commit 03ab3f8c2542632cf85c3150ab694ca3ce368f27 by Jaroslaw Staniek.
Committed on 07/12/2013 at 22:43.
Pushed by staniek into branch 'master'.

Make certain warning messages in Kexi Reports translatable

M  +12   -0    kexi/plugins/reports/kexireportpart.cpp
M  +3    -0    kexi/plugins/reports/kexireportpart.h

http://commits.kde.org/calligra/03ab3f8c2542632cf85c3150ab694ca3ce368f27
Comment 6 Jarosław Staniek 2013-12-08 00:35:44 UTC 
Fixed for 2.9.0, I have not managed to do so for 2.8.0, I am sorry.
Comment 7 Burkhard Lück 2013-12-08 13:07:25 UTC 
Created attachment 83985 [details]
untranslated file types in Project Open dialog

Attachment with untranslated strings in Project Open dialog from master/2.7 compiled from sources running in locale x-test.
Kexi loads the catalog xml_mimetypes with translations of these strings, but apparently has no i18n() calls adding these strings to the filter in the code.
Comment 8 Jarosław Staniek 2013-12-08 16:49:58 UTC 
Thanks Burkhard! It seems that allfiles mimetype has no translated comment, see /usr/share/mime/all/allfiles.xml. KFileWidget/Dialog has own string inside. So I plan to use KFileFilterCombo::defaultFilter(). This way I can avoid extra string, so it can go to 2.8 too.  Committing soon...
Comment 9 Jarosław Staniek 2013-12-08 17:27:15 UTC 
Git commit 8ebd85ba2d944773b14a2096917571dc1259ef4b by Jaroslaw Staniek.
Committed on 08/12/2013 at 16:56.
Pushed by staniek into branch 'calligra/2.8'.

A fix for i18n in open dialogs: allfiles mimetype has no translated comment

Use KFileFilterCombo::defaultFilter() instead. This is remaining fix for:

M  +5    -7    kexi/widget/KexiFileWidget.cpp

http://commits.kde.org/calligra/8ebd85ba2d944773b14a2096917571dc1259ef4b
Comment 10 Jarosław Staniek 2013-12-08 17:33:27 UTC 
Git commit eef9b0a93655e9614155a53d9965d6cf0e1d84c0 by Jaroslaw Staniek.
Committed on 08/12/2013 at 16:56.
Pushed by staniek into branch 'master'.

A fix for i18n in open dialogs: allfiles mimetype has no translated comment

Use KFileFilterCombo::defaultFilter() instead. This is remaining fix for:

M  +5    -7    kexi/widget/KexiFileWidget.cpp

http://commits.kde.org/calligra/eef9b0a93655e9614155a53d9965d6cf0e1d84c0
Comment 11 André Marcelo Alvarenga 2014-01-07 21:39:06 UTC 
(In reply to comment #5)
> Git commit 03ab3f8c2542632cf85c3150ab694ca3ce368f27 by Jaroslaw Staniek.
> Committed on 07/12/2013 at 22:43.
> Pushed by staniek into branch 'master'.
> 
> Make certain warning messages in Kexi Reports translatable
> 
> M  +12   -0    kexi/plugins/reports/kexireportpart.cpp
> M  +3    -0    kexi/plugins/reports/kexireportpart.h
> 
> http://commits.kde.org/calligra/03ab3f8c2542632cf85c3150ab694ca3ce368f27

Jarosław

These strings are still not present in the pot file.


>Git commit 8ebd85ba2d944773b14a2096917571dc1259ef4b by Jaroslaw Staniek.
>Committed on 08/12/2013 at 16:56.
>Pushed by staniek into branch 'calligra/2.8'.
>
>A fix for i18n in open dialogs: allfiles mimetype has no translated comment 
>
>Use KFileFilterCombo::defaultFilter() instead. This is remaining fix for: 
>
>M +5 -7 kexi/widget/KexiFileWidget.cpp http://commits.kde.org/calligra/8ebd85ba2d944773b14a2096917571dc1259ef4b

This string is OK.
Comment 12 Jarosław Staniek 2014-01-10 22:17:33 UTC 
> M  +12   -0    kexi/plugins/reports/kexireportpart.cpp 
> M +3 -0 kexi/plugins/reports/kexireportpart.h 
> > http://commits.kde.org/calligra/03ab3f8c2542632cf85c3150ab694ca3ce368f27 

> These strings are still not present in the pot file.

André, that's expected since this has been only committed to the master branch which is currently for Kexi 2.9. Unfortunately we are unable to add new translations to Kexi 2.8 at this stage.
Comment 13 Burkhard Lück 2014-01-11 11:48:50 UTC 
(In reply to comment #12)
> Unfortunately we are unable to add new translations to Kexi 2.8 at this stage.

String freeze policy of course allows to add previously untranslated string.
Comment 14 Jarosław Staniek 2014-01-12 20:41:38 UTC 
Git commit 06e48a4df0750286b15db4a0b2414769555851b9 by Jaroslaw Staniek.
Committed on 07/12/2013 at 22:43.
Pushed by staniek into branch 'calligra/2.8'.

Make certain warning messages in Kexi Reports translatable

M  +12   -0    kexi/plugins/reports/kexireportpart.cpp
M  +3    -0    kexi/plugins/reports/kexireportpart.h

http://commits.kde.org/calligra/06e48a4df0750286b15db4a0b2414769555851b9
Comment 15 Jarosław Staniek 2014-01-12 20:41:53 UTC 
@Burkhard indeed, pushed to 2.8 too.