Bug 319011 - Difficult to view full plugin description
Summary: Difficult to view full plugin description
Status: RESOLVED FIXED
Alias: None
Product: kdevelop
Classification: Applications
Component: general (show other bugs)
Version: 4.5.0
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: 4.3.0
Assignee: kdevelop-bugs-null
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2013-04-28 08:53 UTC by Victor Varvaryuk
Modified: 2013-10-05 00:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Some plugins have long description which doesn't fit the dialog. An the description is not in the plugin info dialog. (117.21 KB, image/png)
2013-04-28 08:53 UTC, Victor Varvaryuk
Details
Patch for Junior-Job-319011-Difficult-to-view-full-plugin-desc (7.74 KB, patch)
2013-09-30 07:28 UTC, Meenakshi Khorana
Details
Screenshot for correction made to Junior-Job-319011-Difficult-to-view-full-plugin-desc.patch (139.91 KB, image/jpeg)
2013-09-30 07:34 UTC, Meenakshi Khorana
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Varvaryuk 2013-04-28 08:53:15 UTC
Settings -> Configure KDevelop - Plugins
Some plugins have long description which doesn't fit the dialog. An the description is not in the plugin info dialog.

Reproducible: Always
Comment 1 Victor Varvaryuk 2013-04-28 08:53:54 UTC
Created attachment 79507 [details]
Some plugins have long description which doesn't fit the dialog. An the description is not in the plugin info dialog.
Comment 2 Meenakshi Khorana 2013-09-25 09:10:53 UTC
Hi,

I am Meenakshi. I have knowledge of C, C++, QT on Linux. 

I want to work on this issue. I have downloaded the code and compiled the same successfully but not able to move to next step. Can you please help me with some reference/link to understand the code.

Thanks
Comment 3 Milian Wolff 2013-09-26 20:04:54 UTC
The only way to use the same string in both dialogs that I see is to adapt the .cpp files: Instead of the often quite dump short description in the KAboutData, use the same string that is defined for Comment= in the .desktop file.

E.g.:

executeplugin.cpp:
K_EXPORT_PLUGIN(KDevExecuteFactory(KAboutData("kdevexecute", "kdevexecute", ki18n("Execute support"), "0.1", ki18n("Allows running of native apps"), KAboutData::License_GPL)))

Change  ki18n("Allows running of native apps") to ki18n("This plugin allows running of programs with no instrumentor, ie. natively by the current host."), see also kdevexecute.desktop.cmake.

Furthermore, someone should patch the KPluginSelector in kdelibs to show the full text in a tooltip for elided entries.
Comment 4 Meenakshi Khorana 2013-09-30 07:26:36 UTC
(In reply to comment #3)
> The only way to use the same string in both dialogs that I see is to adapt
> the .cpp files: Instead of the often quite dump short description in the
> KAboutData, use the same string that is defined for Comment= in the .desktop
> file.
> 
> E.g.:
> 
> executeplugin.cpp:
> K_EXPORT_PLUGIN(KDevExecuteFactory(KAboutData("kdevexecute", "kdevexecute",
> ki18n("Execute support"), "0.1", ki18n("Allows running of native apps"),
> KAboutData::License_GPL)))
> 
> Change  ki18n("Allows running of native apps") to ki18n("This plugin allows
> running of programs with no instrumentor, ie. natively by the current
> host."), see also kdevexecute.desktop.cmake.
> 
> Furthermore, someone should patch the KPluginSelector in kdelibs to show the
> full text in a tooltip for elided entries.

Hi Milian Wolff,

Thanks for your guidance. I have made changes to core plugins as per your directions.

I am hereby attaching the patch for same for your review. Can you please check and let me know if the changes are correct so that i may apply changes to rest of plugins as well.

PS : I have not made any changes to New Project Wizard and Project Manager View as i found their About to have relevant information. Please suggest if i should make changes to these two or not.

Thanks n Regards,

Meenakshi
Comment 5 Meenakshi Khorana 2013-09-30 07:28:39 UTC
Created attachment 82559 [details]
Patch for Junior-Job-319011-Difficult-to-view-full-plugin-desc
Comment 6 Meenakshi Khorana 2013-09-30 07:34:50 UTC
Created attachment 82560 [details]
Screenshot for correction made to Junior-Job-319011-Difficult-to-view-full-plugin-desc.patch

This screenshot shows the complete content of Plugin description in About Tab
Comment 7 Milian Wolff 2013-09-30 21:55:18 UTC
Hey Meenakshi, please be so kind and upload the patch to reviewboard.kde.org. That is where we can review your code better and give per-line comments etc. pp.

I hope this won't be your last patch, so better start using the proper tools as early as possible :)

Cheers
Comment 8 Milian Wolff 2013-10-03 08:56:17 UTC
Git commit 1787428991e0bf38d94ad275f3bcbca6eb956737 by Milian Wolff, on behalf of Meenakshi Khorana.
Committed on 03/10/2013 at 06:50.
Pushed by mwolff into branch 'master'.

Improve plugin description, which is shown in the About dialog.

Reuse the wording from the .desktop file which is more helpful.
REVIEW: 113030

M  +1    -1    plugins/classbrowser/classbrowserplugin.cpp
M  +1    -1    plugins/contextbrowser/contextbrowser.cpp
M  +1    -1    plugins/dashboard/kdevprojectdashboard.cpp
M  +1    -1    plugins/execute/executeplugin.cpp
M  +1    -1    plugins/filemanager/kdevfilemanagerplugin.cpp
M  +1    -1    plugins/filetemplates/filetemplatesplugin.cpp
M  +1    -1    plugins/openwith/openwithplugin.cpp
M  +1    -1    plugins/quickopen/quickopenplugin.cpp

http://commits.kde.org/kdevplatform/1787428991e0bf38d94ad275f3bcbca6eb956737
Comment 9 Aleix Pol 2013-10-05 00:34:33 UTC
Git commit bac7ec0fffab7e6cab0f38a693764a5921fec63e by Aleix Pol, on behalf of Meenakshi Khorana.
Committed on 05/10/2013 at 00:33.
Pushed by apol into branch 'master'.

Improve plugin description(debugging plugins), which is shown in the About dialog.

Reuse the wording from the .desktop file which is more helpful.

M  +1    -1    debuggers/gdb/debuggerplugin.cpp

http://commits.kde.org/kdevelop/bac7ec0fffab7e6cab0f38a693764a5921fec63e
Comment 10 Aleix Pol 2013-10-05 00:36:04 UTC
Git commit 34d2d18d492b0a13ae9bfda4b9119372dcc4fe60 by Aleix Pol, on behalf of Meenakshi Khorana.
Committed on 05/10/2013 at 00:34.
Pushed by apol into branch 'master'.

Improve plugin description(utilites and version control plugins), which is shown in the About dialog.

Reuse the wording from the .desktop file which is more helpful.
REVIEW: 113092

M  +1    -1    plugins/codeutils/codeutilsplugin.cpp
M  +1    -1    plugins/documentview/kdevdocumentviewplugin.cpp
M  +1    -1    plugins/externalscript/externalscriptplugin.cpp
M  +1    -1    plugins/grepview/grepviewplugin.cpp
M  +1    -1    plugins/konsole/kdevkonsoleviewplugin.cpp
M  +1    -1    plugins/snippet/snippetplugin.cpp
M  +1    -1    plugins/switchtobuddy/switchtobuddyplugin.cpp
M  +1    -1    plugins/vcschangesview/vcschangesviewplugin.cpp

http://commits.kde.org/kdevplatform/34d2d18d492b0a13ae9bfda4b9119372dcc4fe60