Bug 318454 - Seam with Sharpen and Blur filters.
Summary: Seam with Sharpen and Blur filters.
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Sahil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-16 14:59 UTC by Paul Geraskin
Modified: 2018-07-06 05:45 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Seams on Sharpen Filter (1.69 MB, image/png)
2018-07-06 05:43 UTC, reptillia39
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Geraskin 2013-04-16 14:59:25 UTC
Hello devs!

I found an issue with Sharpen and Blur filters. Here is my video:
http://www.youtube.com/watch?v=AC0fOd34OL4

Here is the texture to be used: http://i.imgur.com/926ietP.png

One ramark: Unsharpen Mask filter works ok (no seams). And I also showed Gimp's Seamless Blur filter.

Thanks.
Comment 1 Halla Rempt 2013-05-18 09:24:05 UTC
Interesting... Yes, I can confirm. It must be something about the way we treat the edges of an image.
Comment 2 Dmitry Kazakov 2014-01-14 19:26:56 UTC
Git commit 9f81cdd392a723c5fbebb7a12f01030cbe4b5cce by Dmitry Kazakov.
Committed on 14/01/2014 at 19:24.
Pushed by dkazakov into branch 'krita-testing-kazakov'.

Fixed FFTW convolution worker to work properly in wraparound mode

It had at least two problems:
1) Some memory offset problems causing random pixels accessed
2) Wrapped line iterators working incorrectly when the access rect
   was larger than the wrap rect. The rect iterator still has this
   problem, but at least tells the user that the result is undefined.

M  +10   -21   krita/image/kis_convolution_painter.cc
M  +3    -6    krita/image/kis_convolution_painter.h
M  +230  -201  krita/image/kis_convolution_worker_fft.h
M  +6    -0    krita/image/kis_iterator_ng.h
M  +4    -5    krita/image/kis_selection_filters.cpp
M  +27   -7    krita/image/kis_wrapped_hline_iterator.h
M  +40   -13   krita/image/kis_wrapped_line_iterator_base.h
M  +7    -15   krita/image/kis_wrapped_rect.h
M  +23   -0    krita/image/kis_wrapped_rect_iterator.h
M  +25   -4    krita/image/kis_wrapped_vline_iterator.h
A  +-    --    krita/image/tests/data/paint_device_test/wrapped_iterators_huge_hline_iterator_-6_-6_34_34.png
A  +-    --    krita/image/tests/data/paint_device_test/wrapped_iterators_huge_vline_iterator_-6_-6_34_34.png
M  +103  -2    krita/image/tests/kis_paint_device_test.cpp
M  +3    -0    krita/image/tests/kis_paint_device_test.h
M  +23   -0    krita/image/tiles3/kis_hline_iterator.cpp
M  +5    -1    krita/image/tiles3/kis_hline_iterator.h
M  +23   -0    krita/image/tiles3/kis_vline_iterator.cpp
M  +4    -0    krita/image/tiles3/kis_vline_iterator.h
M  +1    -0    krita/ui/tool/strokes/kis_filter_stroke_strategy.cpp

http://commits.kde.org/calligra/9f81cdd392a723c5fbebb7a12f01030cbe4b5cce
Comment 3 Dmitry Kazakov 2014-01-24 07:57:09 UTC
Git commit 613079f33106124885323024c0be13f55ef776d2 by Dmitry Kazakov.
Committed on 14/01/2014 at 19:24.
Pushed by dkazakov into branch 'calligra/2.8'.

Fixed FFTW convolution worker to work properly in wraparound mode

It had at least two problems:
1) Some memory offset problems causing random pixels accessed
2) Wrapped line iterators working incorrectly when the access rect
   was larger than the wrap rect. The rect iterator still has this
   problem, but at least tells the user that the result is undefined.

M  +10   -21   krita/image/kis_convolution_painter.cc
M  +3    -6    krita/image/kis_convolution_painter.h
M  +230  -201  krita/image/kis_convolution_worker_fft.h
M  +6    -0    krita/image/kis_iterator_ng.h
M  +4    -5    krita/image/kis_selection_filters.cpp
M  +27   -7    krita/image/kis_wrapped_hline_iterator.h
M  +40   -13   krita/image/kis_wrapped_line_iterator_base.h
M  +7    -15   krita/image/kis_wrapped_rect.h
M  +23   -0    krita/image/kis_wrapped_rect_iterator.h
M  +25   -4    krita/image/kis_wrapped_vline_iterator.h
A  +-    --    krita/image/tests/data/paint_device_test/wrapped_iterators_huge_hline_iterator_-6_-6_34_34.png
A  +-    --    krita/image/tests/data/paint_device_test/wrapped_iterators_huge_vline_iterator_-6_-6_34_34.png
M  +103  -2    krita/image/tests/kis_paint_device_test.cpp
M  +3    -0    krita/image/tests/kis_paint_device_test.h
M  +23   -0    krita/image/tiles3/kis_hline_iterator.cpp
M  +5    -1    krita/image/tiles3/kis_hline_iterator.h
M  +23   -0    krita/image/tiles3/kis_vline_iterator.cpp
M  +4    -0    krita/image/tiles3/kis_vline_iterator.h
M  +1    -0    krita/ui/tool/strokes/kis_filter_stroke_strategy.cpp

http://commits.kde.org/calligra/613079f33106124885323024c0be13f55ef776d2
Comment 4 reptillia39 2018-07-06 05:43:14 UTC
Created attachment 113791 [details]
Seams on Sharpen Filter

There is now seam back on Krita 4.2. It shows up on the sharpen sections only.