Bug 317618 - Crash if choosing "First column as label" in default sheet
Summary: Crash if choosing "First column as label" in default sheet
Status: RESOLVED FIXED
Alias: None
Product: calligrachart
Classification: Applications
Component: general (show other bugs)
Version: 2.8 Pre-Alpha
Platform: Microsoft Windows Microsoft Windows
: NOR critical
Target Milestone: ---
Assignee: Inge Wallin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-30 20:53 UTC by Axel
Modified: 2013-06-30 10:32 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Axel 2013-03-30 20:53:45 UTC
Calligra sheets crash if you drag-and-drop a chart-shape to and empty spreadsheet, then selecting "First column as label" in the dialog that appears when releasing the mouse button.

How to recreate:
- Open an empty spreadsheet.
- Drag-and-drop a chart-shape from the "add shape" manu on the lower right, to the spreadsheet.
- Choose "First column as label" in the dialog that pops up.
- Crash.

Reproducible: Always

Steps to Reproduce:
1. Open an empty spreadsheet.
2. Drag-and-drop a chart-shape from the "add shape" manu on the lower right, to the spreadsheet.
3. Choose "First column as label" in the dialog that pops up.
4. Click OK.
Actual Results:  
Calligra sheets crashes.

Expected Results:  
a. Sheets uses the given selection (whole sheet) as data with first column as labels, for the graph.
b. Sheets forces user to enter a valid data area?
Comment 1 Inge Wallin 2013-06-30 08:16:38 UTC
Hi Axel.  Thanks for the distinct bug report.  This made it easy for me to check the bug and I can indeed confirm it.  I also know why it happens so I'm going to fix it immediately.

In the mean time I'm moving this bug to the chartshape product since this is really a bug in the chart, not in sheets.
Comment 2 Inge Wallin 2013-06-30 08:29:36 UTC
Git commit 058a1b0fe1e700d34a0e9c482def14e169b81880 by Inge Wallin.
Committed on 30/06/2013 at 08:14.
Pushed by ingwa into branch 'master'.

Fix bug 317618 - Crash if choosing "First column as label" in default sheet

The bug was that the config widget didn't check that there was
actually at least one dataset before using the "first" one.

Ok to backport to 2.7 and 2.6?

M  +8    -4    plugins/chartshape/ChartConfigWidget.cpp

http://commits.kde.org/calligra/058a1b0fe1e700d34a0e9c482def14e169b81880
Comment 3 Inge Wallin 2013-06-30 08:52:08 UTC
Git commit f5c82651a2ae092fcf8e0a148e513eb25b352dc5 by Inge Wallin.
Committed on 30/06/2013 at 08:14.
Pushed by ingwa into branch 'calligra/2.7'.

Fix bug 317618 - Crash if choosing "First column as label" in default sheet

The bug was that the config widget didn't check that there was
actually at least one dataset before using the "first" one.

Ok to backport to 2.7 and 2.6?

M  +8    -4    plugins/chartshape/ChartConfigWidget.cpp

http://commits.kde.org/calligra/f5c82651a2ae092fcf8e0a148e513eb25b352dc5
Comment 4 Inge Wallin 2013-06-30 10:32:22 UTC
Git commit 70f5cdd580e7a02173bdd12b06256dfb09e39e1f by Inge Wallin.
Committed on 30/06/2013 at 08:14.
Pushed by ingwa into branch 'calligra/2.6'.

Fix bug 317618 - Crash if choosing "First column as label" in default sheet

The bug was that the config widget didn't check that there was
actually at least one dataset before using the "first" one.

Ok to backport to 2.7 and 2.6?

M  +8    -4    plugins/chartshape/ChartConfigWidget.cpp

http://commits.kde.org/calligra/70f5cdd580e7a02173bdd12b06256dfb09e39e1f