Bug 317509 - Add option to set "" instead of NULL for CSV Import
Summary: Add option to set "" instead of NULL for CSV Import
Status: CLOSED FIXED
Alias: None
Product: KEXI
Classification: Applications
Component: Migration/Import/Export (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: 2.7
Assignee: Tomasz Olszak
URL:
Keywords:
Depends on:
Blocks: 313695
  Show dependency tree / graph
 
Reported: 2013-03-28 22:13 UTC by Tomasz Olszak
Modified: 2013-08-01 21:43 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/calligra/a16c3baa70ade1eebb323c755718cf1756f3a0c1
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Olszak 2013-03-28 22:13:24 UTC 
Set "" for text columns instead of NULL in CSV Import by default.
Add option in csv import dialog:
"Import missing text values as empty texts". Option is available under "Configure..." button.
Option should be saved in ImportNULLsAsEmptyText variable and described in kexi/doc/dev/settings.txt

Reproducible: Always
Comment 1 Jarosław Staniek 2013-03-31 18:44:38 UTC 
@tomasz thanks but please do not set it resolved - only set RESOLVED, then CLOSED after the actual commit (in this case to master i.e. 2.7).
Do that using the BUG:xxxxxx line in the _final_ commit message after you get the review, thanks.
Comment 2 Tomasz Olszak 2013-04-17 16:33:50 UTC 
Git commit a16c3baa70ade1eebb323c755718cf1756f3a0c1 by Tomasz Olszak.
Committed on 15/04/2013 at 22:35.
Pushed by tolszak into branch 'master'.

Kexi - By default missing CSV values imported as empty texts.

Now user can choose to import missing texts as empty text values
(current default configuration) or as NULLs (previous behavior) to
destination table. There was a lot of confusion when SQL queries with
condition columnName = '' did not show any results for imported data.
REVIEW: 109806

M  +3    -0    kexi/doc/dev/settings.txt
M  +14   -3    kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
M  +11   -2    kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.cpp
M  +4    -2    kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.h

http://commits.kde.org/calligra/a16c3baa70ade1eebb323c755718cf1756f3a0c1
Comment 3 Tomasz Olszak 2013-04-17 16:33:50 UTC 
Git commit a16c3baa70ade1eebb323c755718cf1756f3a0c1 by Tomasz Olszak.
Committed on 15/04/2013 at 22:35.
Pushed by tolszak into branch 'master'.

Kexi - By default missing CSV values imported as empty texts.

Now user can choose to import missing texts as empty text values
(current default configuration) or as NULLs (previous behavior) to
destination table. There was a lot of confusion when SQL queries with
condition columnName = '' did not show any results for imported data.
REVIEW: 109806

M  +3    -0    kexi/doc/dev/settings.txt
M  +14   -3    kexi/plugins/importexport/csv/kexicsvimportdialog.cpp
M  +11   -2    kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.cpp
M  +4    -2    kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.h

http://commits.kde.org/calligra/a16c3baa70ade1eebb323c755718cf1756f3a0c1