Bug 316290 - plasmate uses the "kexi" icon for the "Data Engine" task
Summary: plasmate uses the "kexi" icon for the "Data Engine" task
Status: RESOLVED FIXED
Alias: None
Product: Plasma SDK
Classification: Plasma
Component: General (show other bugs)
Version: 1.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 08:58 UTC by Jekyll Wu
Modified: 2013-03-23 16:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.0.1


Attachments
showing the blank icon (29.50 KB, image/png)
2013-03-07 08:59 UTC, Jekyll Wu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jekyll Wu 2013-03-07 08:58:48 UTC
There is one line in startpage.cpp: 

    new QListWidgetItem(KIcon("kexi"), i18n("Data Engine"), m_ui.contentTypes);

I'm not sure it is good idea to use one icon dedicated for some application to reprensent "Data Engine". Further more, it seems neither oxygen-icons nor plasmate contain that  icon, so I get a blank icon here. Maybe it is expected to be provided by calligra? But I  have calligra installed in my system.









Reproducible: Always
Comment 1 Jekyll Wu 2013-03-07 08:59:52 UTC
Created attachment 77826 [details]
showing the blank icon
Comment 2 Giorgos Tsiapaliokas 2013-03-07 11:38:02 UTC
The icon lives under kdesupport/oxygen-icons/22x22/apps/kexi.png .
So probably there is something wrong with your system. Do you build
KDE from sources or do you install it from your package manager.

Yes regarding the kexi icon, maybe we should replace that.
I will try to find a more suitable icon and also I would like to see
what other believe.

I will mark the bug as needsinfo(from us not you :).
Comment 3 Jekyll Wu 2013-03-07 11:54:55 UTC
(In reply to comment #2)
> The icon lives under kdesupport/oxygen-icons/22x22/apps/kexi.png .

http://websvn.kde.org/trunk/kdesupport/oxygen-icons/22x22/apps/ doesn't list that icon.

> So probably there is something wrong with your system. Do you build
> KDE from sources or do you install it from your package manager.

The issue exists in both Archlinux(4.10.1) and Gentoo(built from git master through live ebuild) .
Comment 4 Jekyll Wu 2013-03-07 15:13:21 UTC
OK, find the cause:

commit 5c13da3f0f40b2966318eb303c0fbccf6e897da4
Author: kossebau <kossebau@283d02a7-25f6-0310-bc7c-ecb5cbfe19da>
Date:   8 weeks ago

    Remove icons for karbon, kexi, krita
    
    As dicussed on ml kde-artists: http://lists.kde.org/?t=135767541700004&r=1&w=2
    
    
    git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/oxygen-icons@1331951 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
Comment 5 Giorgos Tsiapaliokas 2013-03-20 17:50:41 UTC
Git commit 6ce5d3fe5c818ac737f163537d5e9550f65e85a0 by Giorgos Tsiapaliokas.
Committed on 15/03/2013 at 20:35.
Pushed by tsiapaliwkas into branch 'terietor/BUG/316290'.

Don't use the kexi icon for the dataengine.
Use the plasma icon
REVIEW: 109507

M  +1    -1    plasmate/startpage.cpp

http://commits.kde.org/plasmate/6ce5d3fe5c818ac737f163537d5e9550f65e85a0