Bug 316175 - Notifications are emitted for messages sent before the text-ui initialised
Summary: Notifications are emitted for messages sent before the text-ui initialised
Status: RESOLVED FIXED
Alias: None
Product: telepathy
Classification: Frameworks and Libraries
Component: text-ui-message-filters (show other bugs)
Version: git-latest
Platform: Other Linux
: NOR normal
Target Milestone: 0.6.0
Assignee: Telepathy Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-05 14:17 UTC by Daniele E. Domenichelli
Modified: 2013-03-17 13:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.6.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniele E. Domenichelli 2013-03-05 14:17:51 UTC
When the text ui is not open, if you receive an highlighted message, the notification is not emitted immediately (even though you get the notification from the approver)
When the text ui is opened, all the queued messages spam a notification at the same time.
Comment 1 Daniele E. Domenichelli 2013-03-10 23:45:40 UTC
Adding another annoying behavior, that is actually the same bug.
When you receive an highlighted message when the chat ui is closed, you receive the normal notification with it's normal sound. When you open the chat ui you receive another notification with the highlighted message sound for the same message.
Comment 2 David Edmundson 2013-03-17 00:38:23 UTC
Updated title.

What's happening here is that we now process notifications when we add a message to the chat window NOT when a new message arrives.

Normally this is the same thing, but it means we now have notifications for the messages which were already shown by the approver when we process the existing messageQueue on startup.
Comment 3 David Edmundson 2013-03-17 13:20:39 UTC
Git commit 8c04eda2c73d3093766283e20f483c15c881968b by David Edmundson, on behalf of Stefan Eggers.
Committed on 17/03/2013 at 14:16.
Pushed by davidedmundson into branch 'master'.

Suppress notifications while writing out messages from backlog
REVIEW: 109535

M  +6    -4    lib/chat-widget.cpp
M  +1    -1    lib/chat-widget.h

http://commits.kde.org/telepathy-text-ui/8c04eda2c73d3093766283e20f483c15c881968b