Bug 315904 - In twinview, don't change _both_ views when using 'find' in the view without focus
Summary: In twinview, don't change _both_ views when using 'find' in the view without ...
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: search (show other bugs)
Version: 2.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-28 13:58 UTC by Christian Reiner
Modified: 2014-08-10 17:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Reiner 2013-02-28 13:58:56 UTC
When using twinview (two file systems view inside dolphin side by side) you can open the 'find' bar atop each view separately. The 'find' action works great but there is a small logical glitch: When using the 'find' action atop the view that does NOT have focus then _both_ views are cleaned. Instead I would expect only the view who actually carries the 'find' bar to be cleaned to receive the find results. The other view should be left alone, especially since it often servers another purpose, its content being important. 

A simple solution would be to accept input to the 'find' bar only inside the focused view. The clean solution would be to actively decide which new to use to show the find results. 

Reproducible: Always

Steps to Reproduce:
1. open twinview
2. open a 'find' bar
3. focus the other view without find bar
4. use the find bar on the view _without_ focus
Actual Results:  
Both views are cleared. 

Expected Results:  
Only the veiw with the used find bar should be modifed.
Comment 1 Frank Reininghaus 2013-02-28 19:06:30 UTC
Thanks for the bug report, I can confirm the problem.
Comment 2 Emmanuel Pescosta 2014-05-30 09:45:13 UTC
Can you still reproduce this problem in Dolphin 4.13?
Comment 3 Emmanuel Pescosta 2014-08-10 17:05:00 UTC
commit dc7ff2e01370899af8cab343352f67f5ef474653
Author: Emmanuel Pescosta <emmanuelpescosta099@gmail.com>
Date:   Sun Aug 10 18:52:06 2014 +0200

Implemented DolphinTabWidget class to encapsulate the tab handling from DolphinMainWindow.

REVIEW: 119115

http://quickgit.kde.org/?p=kde-baseapps.git&a=commit&h=dc7ff2e01370899af8cab343352f67f5ef474653